Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on commons-collections4-4.1.jar #575

Closed
rmoetwil opened this issue Sep 23, 2016 · 4 comments
Closed

False positive on commons-collections4-4.1.jar #575

rmoetwil opened this issue Sep 23, 2016 · 4 comments

Comments

@rmoetwil
Copy link

rmoetwil commented Sep 23, 2016

We upgraded from v1.3.6 to v1.4.3 and got a vulnerability finding (High) on commons-collections4-4.1.jar
According to https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-6420 this version should be ok.

Can it be related to version parsing errors reported earlier and maybe also fixed since the release of 1.4.3?

https://mvnrepository.com/artifact/org.apache.commons/commons-collections4
CVE-2015-6420

<dependency>
    <groupId>org.apache.commons</groupId>
    <artifactId>commons-collections4</artifactId>
    <version>4.1</version>
</dependency>
@jeremylong
Copy link
Owner

Unfortunately, this false positive is cropping up due to the temporary fix for issue #534. I'll try to resolve the version number matching algorithm next. For now, you should be able to generate a suppression rule for this.

@v6ak
Copy link

v6ak commented Jan 2, 2017

I've found this behavior, too. There seems to be some incorrect version detected in the CPE identifier. See https://gist.github.com/v6ak/68dbc738b5789eead689fda02570add4 . There are two reproduction cases and two cases where the version is resolved correctly. Maybe ODC tries to use version in CPE dictionary, so this is used over the actual version.

@jeremylong
Copy link
Owner

I added a version evidence filter to dependency-check that removes the reported false positive and others. The new filter will be included in the next release.

Thanks for reporting this!

--Jeremy

@lock
Copy link

lock bot commented Sep 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants