Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump logback.version from 1.2.11 to 1.3.0 #4786

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2022

Bumps logback.version from 1.2.11 to 1.4.0.
Updates logback-core from 1.2.11 to 1.4.0

Commits

Updates logback-classic from 1.2.11 to 1.4.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `logback.version` from 1.2.11 to 1.4.0.

Updates `logback-core` from 1.2.11 to 1.4.0
- [Release notes](https://github.com/qos-ch/logback/releases)
- [Commits](qos-ch/logback@v_1.2.11...v_1.4.0)

Updates `logback-classic` from 1.2.11 to 1.4.0
- [Release notes](https://github.com/qos-ch/logback/releases)
- [Commits](qos-ch/logback@v_1.2.11...v_1.4.0)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies java Pull requests that update Java code labels Aug 29, 2022
@aikebah
Copy link
Collaborator

aikebah commented Aug 29, 2022

@jeremylong should bump to 1.3.0 instead to retain Java 8 compatibility see qos.ch logback news

pom.xml Outdated Show resolved Hide resolved
@jeremylong jeremylong changed the title Bump logback.version from 1.2.11 to 1.4.0 Bump logback.version from 1.2.11 to 1.3.0 Aug 29, 2022
@aikebah
Copy link
Collaborator

aikebah commented Sep 1, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 1, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@aikebah
Copy link
Collaborator

aikebah commented Sep 2, 2022

@jeremylong I wrongly assumed that the slf4j 2 api upgrade was not yet in, but now see that it is in, but didn't trigger issues yet (but likely already did log warnings on the logging as per https://www.slf4j.org/faq.html#changesInVersion200) as the implementation of the 1.7 series that the code depends on was still available in logback

@jeremylong
Copy link
Owner

@dependabot ignore this dependency

@dependabot dependabot bot closed this Sep 20, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 20, 2022

OK, I won't notify you about any of these dependencies again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/maven/logback.version-1.4.0 branch September 20, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants