Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mirror.sh to fix DELAY Override #124

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

aristo9999999999
Copy link
Contributor

This primarily fix situation where DELAY override is incorrect.

Previous behaviors:

  • If DELAY is unset, will set DELAY_ARG to "--delay=" (empty string after equal sign)
  • If DELAY is set, DELAY_ARG will be set to "--delay=10000" if NVD_API_KEY unspecified. DELAY value will never be used.

Changed Behavior

  • If DELAY is unset,
    • if NVD_API_KEY unspecified, DELAY_ARG will be set to "--delay=10000"
    • if NVD_API_KEY specified, DELAY_ARG will be empty string (I assume will default to value in CLI)
  • If DELAY is set , for example to "1234", DELAY_ARG will be set to "--delay=1234"

This primarily fix situation where DELAY override is incorrect.

Previous behaviors:
* If DELAY is unset, will set DELAY_ARG to "--delay=" (empty string after equal sign) 
* If DELAY is set, DELAY_ARG will be set to "--delay=10000" if NVD_API_KEY unspecified and will not correctly set DELAY value
@jeremylong
Copy link
Owner

thanks!

@jeremylong jeremylong merged commit 6c2bd6b into jeremylong:main Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants