feat(shulker-operator): add the possibility to use custom server jars

[jeremylvln]

Closes #252
Closes #253

[codecov]

Codecov Report

Merging #254 (41e1ecd) into main (0562a8d) will increase coverage by 0.31%.
The diff coverage is 94.87%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   30.38%   30.70%   +0.31%     
==========================================
  Files          57       57              
  Lines        3090     3107      +17     
==========================================
+ Hits          939      954      +15     
- Misses       2151     2153       +2     

Flag	Coverage Δ
shulker-addon-matchmaking	21.58% <ø> (ø)
shulker-crds	92.30% <ø> (ø)
shulker-operator	57.96% <94.87%> (+0.36%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...lker-operator/src/reconcilers/proxy_fleet/fleet.rs	79.24% <100.00%> (ø)
...tor/src/reconcilers/minecraft_server/gameserver.rs	91.02% <94.11%> (-0.22%)	⬇️

[jeremylvln]

Hi @TropicLegend, the custom server JAR feature should work, I do not have the time to test it tonight but will do tomorrow :)

[TropicLegend]

Hi @TropicLegend, the custom server JAR feature should work, I do not have the time to test it tonight but will do tomorrow :)

Oh wow that was fast. I will try it out later today. Thank you!

[TropicLegend]

I uninstalled the shulker instance that was there before.
Then I downloaded the git repository and installed shulker through helm again.
Unfortunately if I try to use a customJar I get this error:

error: error validating "minecraft-server-fleet.yaml": error validating data: ValidationError(MinecraftServerFleet.spec.template.spec.version): unknown field "customJar" in io.shulkermc.v1alpha1.MinecraftServerFleet.spec.template.spec.version; if you choose to ignore these errors, turn validation off with --validate=false

My Config:

apiVersion: shulkermc.io/v1alpha1
kind: MinecraftServerFleet
metadata:
  name: ca-server
  namespace: minecraft-network
spec:
  clusterRef:
    name: fl-net
  replicas: 1
  template:
    spec:
      podOverrides:
        resources:
          requests:
            memory: "512Mi"
            cpu: "500m"
          limits:
            memory: "2048Mi"
            cpu: "4000m"
      clusterRef:
        name: fl-net
      tags:
        - lobby
      version:
        channel: Paper
        name: '1.20.2'
        customJar:
         - url: https://cloud.xxxx.de/s/oeebb6PjkDZiX3c/download/asp-server.jar
      config:
        plugins:
          - url: https://cloud.xxxx.de/s/fCn6TWGQfaHcMnz/download/EssentialsX-2.20.1.jar
          - url: https://cloud.xxxx.de/s/HjdfDzpgGAjRw9r/download/Chunky-1.3.92.jar
          - url: https://cloud.xxxx.de/s/KX5GoWBpAjSMXj2/download/plugin-1.20.2-R0.1-SNAPSHOT%20-%20Advanced%20Slime%20Paper.jar

[TropicLegend]

@jeremylvln Could there possibly be a reason why it does not work for me?

[jeremylvln]

@jeremylvln Could there possibly be a reason why it does not work for me?

There is no auto-build on the pull requests, if you want to test this specific code you'll have to build & publish yourself the image. I did not had the time to merge it (so you'll be able to test), but I will do hopefully today :)

[TropicLegend]

@jeremylvln Could there possibly be a reason why it does not work for me?

There is no auto-build on the pull requests, if you want to test this specific code you'll have to build & publish yourself the image. I did not had the time to merge it (so you'll be able to test), but I will do hopefully today :)

ah, okay. I was not aware of that. Thank you!
Then I will wait until the build is released :D
Just so I know for the future, how to build the image?

[jeremylvln]

@jeremylvln Could there possibly be a reason why it does not work for me?

There is no auto-build on the pull requests, if you want to test this specific code you'll have to build & publish yourself the image. I did not had the time to merge it (so you'll be able to test), but I will do hopefully today :)

ah, okay. I was not aware of that. Thank you! Then I will wait until the build is released :D Just so I know for the future, how to build the image?

Its a bit overcomplicated to build it haha, I definitely need to smooth that.

By the way, I just tested this PR and everything works, so I'll merge it. I'll release after the volume issue. Until then, you can set the image.tag Helm value for the controller to next so it will use the latest build :)

[TropicLegend]

@jeremylvln Could there possibly be a reason why it does not work for me?

There is no auto-build on the pull requests, if you want to test this specific code you'll have to build & publish yourself the image. I did not had the time to merge it (so you'll be able to test), but I will do hopefully today :)

ah, okay. I was not aware of that. Thank you! Then I will wait until the build is released :D Just so I know for the future, how to build the image?

Its a bit overcomplicated to build it haha, I definitely need to smooth that.

By the way, I just tested this PR and everything works, so I'll merge it. I'll release after the volume issue. Until then, you can set the image.tag Helm value for the controller to next so it will use the latest build :)

Using the "next" release, the customJar also works for me.
Thank you very much 👍.

[github-actions]

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

• v0.5.0
• v0.5.0
• GitHub release

Your semantic-release bot 📦🚀