feat: support mounting custom volumes to servers #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 30.70% 30.81% +0.11%
==========================================
Files 57 57
Lines 3107 3115 +8
==========================================
+ Hits 954 960 +6
- Misses 2153 2155 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeremylvln
force-pushed
the
feat/support-extra-volumes
branch
from
3a0da17
to
c4cde1c
Compare
jeremylvln
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-03) ### ✨ Features ✨ * **shulker-operator:** add the possibility to use custom server jars ([#254](#254)) ([72844b1](72844b1)) * support mounting custom volumes to servers ([#281](#281)) ([5e7f774](5e7f774)) ### 🐛 Bug Fixes 🐛 * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.29.0 ([#276](#276)) ([e8c9e74](e8c9e74)) * **deps:** update dependency com.google.guava:guava to v33 ([#312](#312)) ([49fe6bc](49fe6bc)) * **deps:** update dependency com.google.protobuf:protobuf-java to v3.25.1 ([#257](#257)) ([ba9d2cf](ba9d2cf)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.59.1 ([#271](#271)) ([e2c7230](e2c7230)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.60.0 ([#285](#285)) ([a60a643](a60a643)) * **deps:** update dependency net.kyori:adventure-api to v4.15.0 ([#311](#311)) ([5b66eec](5b66eec)) * **deps:** update dependency redis.clients:jedis to v5.1.0 ([#266](#266)) ([81a52a7](81a52a7)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.2 ([#258](#258)) ([10af60c](10af60c)) * **deps:** update grpc to v1.59.1 ([#272](#272)) ([75c4cdd](75c4cdd)) * **deps:** update grpc to v1.60.0 ([#286](#286)) ([f538bf4](f538bf4)) * regenerate crds ([456fc8b](456fc8b)) * **shulker-operator:** custom annotations not added to ProxyFleet service ([#273](#273)) ([83e5f53](83e5f53))
jeremylvln
pushed a commit
that referenced
this pull request
Jan 3, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-03) ### ✨ Features ✨ * **shulker-operator:** add the possibility to use custom server jars ([#254](#254)) ([72844b1](72844b1)) * support mounting custom volumes to servers ([#281](#281)) ([5e7f774](5e7f774)) ### 🐛 Bug Fixes 🐛 * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.29.0 ([#276](#276)) ([e8c9e74](e8c9e74)) * **deps:** update dependency com.google.guava:guava to v33 ([#312](#312)) ([49fe6bc](49fe6bc)) * **deps:** update dependency com.google.protobuf:protobuf-java to v3.25.1 ([#257](#257)) ([ba9d2cf](ba9d2cf)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.59.1 ([#271](#271)) ([e2c7230](e2c7230)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.60.0 ([#285](#285)) ([a60a643](a60a643)) * **deps:** update dependency net.kyori:adventure-api to v4.15.0 ([#311](#311)) ([5b66eec](5b66eec)) * **deps:** update dependency redis.clients:jedis to v5.1.0 ([#266](#266)) ([81a52a7](81a52a7)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.2 ([#258](#258)) ([10af60c](10af60c)) * **deps:** update grpc to v1.59.1 ([#272](#272)) ([75c4cdd](75c4cdd)) * **deps:** update grpc to v1.60.0 ([#286](#286)) ([f538bf4](f538bf4)) * regenerate crds ([456fc8b](456fc8b)) * **shulker-operator:** custom annotations not added to ProxyFleet service ([#273](#273)) ([83e5f53](83e5f53))
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
TropicalShadow
pushed a commit
to BridgeSplash/Shulker
that referenced
this pull request
Jan 27, 2024
## 1.0.0 (2024-01-27) ### ✨ Features ✨ * ability to add custom server properties ([497521f](497521f)) * add gradle base for support plugins ([62dba66](62dba66)) * add minecraft cluster api ([af183f4](af183f4)) * add nodeselector to pod overrides ([123f169](123f169)) * add proxy deployment api ([1fabf97](1fabf97)) * add support for patch archives ([4dfe495](4dfe495)) * add support for plugins on proxy ([6dc8750](6dc8750)) * add support for world and plugins ([e50b0b2](e50b0b2)) * add tolerations to pod overrides ([4290b19](4290b19)) * configure limbo for cluster ([9c9dc99](9c9dc99)) * create proxy directory plugin ([791a4d9](791a4d9)) * create proxy rbac ([20d2421](20d2421)) * custom plugin folder location for proxy and server ([5f602b4](5f602b4)) * **deploy:** add agones allocator env ([929c652](929c652)) * force proxy deployment to have a cluster ref, download plugins on start ([b787fa1](b787fa1)) * generate java crds ([11aae37](11aae37)) * **google-agones-sdk:** generate Rust SDK and update proto ([5d02808](5d02808)) * **google-open-match-sdk:** create auto-generated java sdk ([5235405](5235405)) * **google-open-match-sdk:** create auto-generated sdk ([68f443d](68f443d)) * **google-open-match-sdk:** regenerate java sdk ([e700916](e700916)) * handle rcon secret ([43a1afa](43a1afa)) * implement lifecycle strategies on server ([jeremylvln#356](https://github.com/bridgesplash/Shulker/issues/356)) ([a8a33ab](a8a33ab)) * implement scale for proxy deployment ([c792ff1](c792ff1)) * **java-sdk:** create java sdk ([745b299](745b299)) * Minestom server agent support ([1e1add3](1e1add3)) * move API source to agents projects [breaking change] ([c307c02](c307c02)) * **operator:** add built-in autoscaling to fleets ([jeremylvln#112](https://github.com/bridgesplash/Shulker/issues/112)) ([1dc72a1](1dc72a1)) * **operator:** add Image in PodOverrides for Proxy and MinecraftServer ([jeremylvln#98](https://github.com/bridgesplash/Shulker/issues/98)) ([8f649f6](8f649f6)) * **operator:** use latest itzg images ([jeremylvln#100](https://github.com/bridgesplash/Shulker/issues/100)) ([5ae0bd2](5ae0bd2)) * remove usage of macro_use ([jeremylvln#197](https://github.com/bridgesplash/Shulker/issues/197)) ([74d4067](74d4067)) * rework manifests ([07a0bae](07a0bae)) * route proxy to server internal network through internal DNS ([jeremylvln#357](https://github.com/bridgesplash/Shulker/issues/357)) ([5f12300](5f12300)) * **server-agent:** add explicit api-version in paper yml ([5ab4147](5ab4147)) * **shulker-addon-matchmaking:** create director and mmf ([jeremylvln#210](https://github.com/bridgesplash/Shulker/issues/210)) ([72cd61f](72cd61f)) * **shulker-crds:** add network admins list to cluster ([86d7135](86d7135)) * **shulker-crds:** add redis provided spec to cluster ([490db51](490db51)) * **shulker-crds:** update crds ([ab935b7](ab935b7)) * **shulker-crds:** update crds ([b29d732](b29d732)) * **shulker-crds:** update crds ([c159ad5](c159ad5)) * **shulker-crds:** update kubernetes client ([ddc0a63](ddc0a63)) * **shulker-operator:** add a Maven snapshot resolver ([2b82d07](2b82d07)) * **shulker-operator:** add ability to register hook with order ([76f6730](76f6730)) * **shulker-operator:** add support for folia ([5244336](5244336)) * **shulker-operator:** add the possibility to use custom server jars ([jeremylvln#254](https://github.com/bridgesplash/Shulker/issues/254)) ([72844b1](72844b1)) * **shulker-operator:** decouple version of agent from the operator ([a231cfe](a231cfe)) * **shulker-operator:** deploy a managed single node redis ([jeremylvln#183](https://github.com/bridgesplash/Shulker/issues/183)) ([3e99751](3e99751)) * **shulker-operator:** inject SHULKER_NETWORK_ADMINS env to proxies and servers ([cafc0cb](cafc0cb)) * **shulker-operator:** rework summon sdk method to try to allocate an existing server first ([3b661a1](3b661a1)) * **shulker-proxy-agent:** add glist, gtp and gfind commands ([850af26](850af26)) * **shulker-proxy-agent:** display global player count on ping ([c29eac1](c29eac1)) * **shulker-proxy-agent:** grant all permissions to network admins ([0f96077](0f96077)) * **shulker-proxy-agent:** listen on teleport player pub sub ([e4f8d17](e4f8d17)) * **shulker-proxy-agent:** query mojang api to get unknown player names or ids ([e7eb734](e7eb734)) * **shulker-proxy-agent:** sync proxies and players in Redis ([ec0211c](ec0211c)) * **shulker-proxy-directory:** add connect listener to send to limbo ([6cae574](6cae574)) * **shulker-proxy-directory:** fix concurrent exception on proxy servers ([b4f96f8](b4f96f8)) * **shulker-proxy-directory:** fix concurrent exception on proxy servers ([97e85b8](97e85b8)) * **shulker-sdk:** add convenient Java wrapper ([4ac0c8c](4ac0c8c)) * **shulker-server-agent:** grant network admins as operators ([d4fccbf](d4fccbf)) * **shulker-server-agent:** hybrid support between paper and folia ([0b151eb](0b151eb)) * support mounting custom volumes to servers ([jeremylvln#281](https://github.com/bridgesplash/Shulker/issues/281)) ([5e7f774](5e7f774)) ### 🐛 Bug Fixes 🐛 * add configuration to helm yaml ([f5520e0](f5520e0)) * add minestom as a MinecraftServerVersion in minecraft_server.rs ([5583134](5583134)) * **agent:** unregisterServer method map mismatch ([jeremylvln#94](https://github.com/bridgesplash/Shulker/issues/94)) ([b8a8d31](b8a8d31)) * correctly update proxy service annotations ([40db68b](40db68b)) * crash when no MaxPlayers is provided in MinecraftServer spec ([a8bfcf8](a8bfcf8)) * **deps:** manual bump ([jeremylvln#128](https://github.com/bridgesplash/Shulker/issues/128)) ([7d9dbdf](7d9dbdf)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.29.0 ([jeremylvln#276](https://github.com/bridgesplash/Shulker/issues/276)) ([e8c9e74](e8c9e74)) * **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.30.0 ([jeremylvln#350](https://github.com/bridgesplash/Shulker/issues/350)) ([c6e14a3](c6e14a3)) * **deps:** update dependency com.google.guava:guava to v33 ([jeremylvln#312](https://github.com/bridgesplash/Shulker/issues/312)) ([49fe6bc](49fe6bc)) * **deps:** update dependency com.google.protobuf:protobuf-java to v3.25.1 ([jeremylvln#257](https://github.com/bridgesplash/Shulker/issues/257)) ([ba9d2cf](ba9d2cf)) * **deps:** update dependency com.google.protobuf:protobuf-java to v3.25.2 ([jeremylvln#361](https://github.com/bridgesplash/Shulker/issues/361)) ([493ba07](493ba07)) * **deps:** update dependency io.fabric8:kubernetes-client to v6.3.1 ([jeremylvln#82](https://github.com/bridgesplash/Shulker/issues/82)) ([2222ee3](2222ee3)) * **deps:** update dependency io.fabric8:kubernetes-client-api to v6.3.1 ([jeremylvln#83](https://github.com/bridgesplash/Shulker/issues/83)) ([0cd18c3](0cd18c3)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.59.1 ([jeremylvln#271](https://github.com/bridgesplash/Shulker/issues/271)) ([e2c7230](e2c7230)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.60.0 ([jeremylvln#285](https://github.com/bridgesplash/Shulker/issues/285)) ([a60a643](a60a643)) * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.60.1 ([jeremylvln#322](https://github.com/bridgesplash/Shulker/issues/322)) ([8303b6e](8303b6e)) * **deps:** update dependency io.grpc:grpc-protobuf to v1.59.0 ([jeremylvln#199](https://github.com/bridgesplash/Shulker/issues/199)) ([9d83dbc](9d83dbc)) * **deps:** update dependency io.grpc:grpc-services to v1.59.0 ([jeremylvln#200](https://github.com/bridgesplash/Shulker/issues/200)) ([c501357](c501357)) * **deps:** update dependency io.grpc:grpc-stub to v1.59.0 ([jeremylvln#201](https://github.com/bridgesplash/Shulker/issues/201)) ([e422ef2](e422ef2)) * **deps:** update dependency net.kyori:adventure-api to v4.12.0 ([jeremylvln#79](https://github.com/bridgesplash/Shulker/issues/79)) ([cda12ec](cda12ec)) * **deps:** update dependency net.kyori:adventure-api to v4.14.0 ([jeremylvln#137](https://github.com/bridgesplash/Shulker/issues/137)) ([8cea5eb](8cea5eb)) * **deps:** update dependency net.kyori:adventure-api to v4.15.0 ([jeremylvln#311](https://github.com/bridgesplash/Shulker/issues/311)) ([5b66eec](5b66eec)) * **deps:** update dependency net.kyori:adventure-platform-bungeecord to v4.3.0 ([jeremylvln#138](https://github.com/bridgesplash/Shulker/issues/138)) ([293d43d](293d43d)) * **deps:** update dependency net.kyori:adventure-platform-bungeecord to v4.3.1 ([jeremylvln#145](https://github.com/bridgesplash/Shulker/issues/145)) ([e5e2c84](e5e2c84)) * **deps:** update dependency net.kyori:adventure-platform-bungeecord to v4.3.2 ([jeremylvln#326](https://github.com/bridgesplash/Shulker/issues/326)) ([a9d6e34](a9d6e34)) * **deps:** update dependency net.md-5:bungeecord-api to v1.20-r0.1 ([jeremylvln#139](https://github.com/bridgesplash/Shulker/issues/139)) ([355db1e](355db1e)) * **deps:** update dependency redis.clients:jedis to v5.1.0 ([jeremylvln#266](https://github.com/bridgesplash/Shulker/issues/266)) ([81a52a7](81a52a7)) * **deps:** update fabric8-kubernetes-client monorepo to v6.10.0 ([jeremylvln#360](https://github.com/bridgesplash/Shulker/issues/360)) ([63548a2](63548a2)) * **deps:** update fabric8-kubernetes-client monorepo to v6.8.1 ([jeremylvln#140](https://github.com/bridgesplash/Shulker/issues/140)) ([47704cf](47704cf)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.0 ([jeremylvln#168](https://github.com/bridgesplash/Shulker/issues/168)) ([62b1517](62b1517)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.1 ([jeremylvln#214](https://github.com/bridgesplash/Shulker/issues/214)) ([022903c](022903c)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.2 ([jeremylvln#228](https://github.com/bridgesplash/Shulker/issues/228)) ([9c5a37f](9c5a37f)) * **deps:** update fabric8-kubernetes-client monorepo to v6.9.2 ([jeremylvln#258](https://github.com/bridgesplash/Shulker/issues/258)) ([10af60c](10af60c)) * **deps:** update grpc to v1.59.1 ([jeremylvln#272](https://github.com/bridgesplash/Shulker/issues/272)) ([75c4cdd](75c4cdd)) * **deps:** update grpc to v1.60.0 ([jeremylvln#286](https://github.com/bridgesplash/Shulker/issues/286)) ([f538bf4](f538bf4)) * **deps:** update grpc to v1.60.1 ([jeremylvln#323](https://github.com/bridgesplash/Shulker/issues/323)) ([87e8641](87e8641)) * **deps:** update kubernetes packages to v0.23.4 ([jeremylvln#52](https://github.com/bridgesplash/Shulker/issues/52)) ([d3ec1eb](d3ec1eb)) * **deps:** update module github.com/google/uuid to v1.3.0 ([jeremylvln#55](https://github.com/bridgesplash/Shulker/issues/55)) ([a75561c](a75561c)) * **deps:** update module github.com/pelletier/go-toml/v2 to v2.0.6 ([jeremylvln#78](https://github.com/bridgesplash/Shulker/issues/78)) ([d4e4232](d4e4232)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.0 ([jeremylvln#75](https://github.com/bridgesplash/Shulker/issues/75)) ([56ff2b1](56ff2b1)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.1 ([jeremylvln#87](https://github.com/bridgesplash/Shulker/issues/87)) ([58f3ea1](58f3ea1)) * **Dockerfile:** add pkg directory ([5d1a201](5d1a201)) * **Dockerfile:** fix ([820ae3d](820ae3d)) * exclude files in .gitignore for gradle auto-import ([f6a2ea3](f6a2ea3)) * github actions remove gradle publication ([42f711b](42f711b)) * listen and update correctly the resources ([e69d3de](e69d3de)) * **operator:** missing owns on controllers ([abd625b](abd625b)) * passing wrong argument to serde ([c57d732](c57d732)) * **proxy-directory:** add minecraft cluster to gson map ([655e052](655e052)) * **proxy-directory:** deserialize response manually ([1b45563](1b45563)) * **proxy-directory:** move to informer based watching ([028eda2](028eda2)) * **proxy-directory:** typo on type and add sync fix ([44e2417](44e2417)) * **proxy-directory:** use namespaced call ([5c5005a](5c5005a)) * **proxy-directory:** watch of resource directly ([2a34deb](2a34deb)) * publish java libraries as normal jar ([d4083d1](d4083d1)) * regenerate crds ([456fc8b](456fc8b)) * remove duplicate entries from .gitignore ([c907668](c907668)) * remove files related to gradle auto-import ([d57c7c2](d57c7c2)) * scripts/publish_docker.sh update docker push image script ([jeremylvln#80](https://github.com/bridgesplash/Shulker/issues/80)) ([5e27295](5e27295)) * set force default server in proxy configuration ([51d805c](51d805c)) * **shulker-crds:** use native default system whenever possible ([jeremylvln#153](https://github.com/bridgesplash/Shulker/issues/153)) ([2f89a51](2f89a51)) * **shulker-kube-utils:** use axum in metrics ([9608cfc](9608cfc)) * **shulker-operator:** assert valid cluster ref before reconciling ([jeremylvln#184](https://github.com/bridgesplash/Shulker/issues/184)) ([c207cce](c207cce)) * **shulker-operator:** custom annotations not added to ProxyFleet service ([jeremylvln#273](https://github.com/bridgesplash/Shulker/issues/273)) ([83e5f53](83e5f53)) * **shulker-operator:** custom server properties not being passed to the server ([2c75cf3](2c75cf3)) * **shulker-operator:** fleet labels not added to GameServers from MinecraftServerFleets ([4cf98b9](4cf98b9)) * **shulker-operator:** inject proper pod annotation for default container ([25becea](25becea)) * **shulker-operator:** keep extra annotations when reconciling a resource ([229b50c](229b50c)) * **shulker-operator:** network admins are optional ([020a1d0](020a1d0)) * **shulker-operator:** patch existing resources with a fresh spec ([d2fcea3](d2fcea3)) * **shulker-operator:** plugins and patches joined with bad separator ([13d142e](13d142e)) * **shulker-operator:** prevent proxy connections only if LoadBalancer or NodePort service ([e8a4993](e8a4993)) * **shulker-operator:** resolve maven secret in correct namespace ([a7b8d14](a7b8d14)) * **shulker-proxy-agent:** correctly create Jedis pool with credentials ([d3231d4](d3231d4)) * **shulker-proxy-agent:** having no network admins tries to parse an empty string uuid ([47e26e8](47e26e8)) * **shulker-proxy-agent:** sync players, proxies and servers in Redis ([06529f6](06529f6)) * **shulker-proxy-agent:** use a dedicated thread pool for redis pubsub ([afb575d](afb575d)) * **shulker-proxy-directory:** build ([2ab5585](2ab5585)) * **shulker-proxy-directory:** don't remove lobby from server list ([127541a](127541a)) * **shulker-proxy-directory:** name of the default target ([4470140](4470140)) * **shulker-proxy-directory:** name of the default target ([8d4de7a](8d4de7a)) * **shulker-proxy-directory:** server name is first part ([f9e1694](f9e1694)) * **shulker-sdk:** already set the Netty library as runtime dependency ([970c47a](970c47a)) * **shulker-server-agent:** use new agones package ([1adac9b](1adac9b)) ###⚠️ Reverts⚠️ * Revert "chore(deps): update nrwl monorepo to v17.1.1 (jeremylvln#239)" (jeremylvln#240) ([6080f92](6080f92)), closes [jeremylvln#239](https://github.com/bridgesplash/Shulker/issues/239) [jeremylvln#240](https://github.com/bridgesplash/Shulker/issues/240) ### 📚 Documentation 📚 * add @PSNRigner as a contributor ([a374642](a374642)) * add @Thog as a contributor ([8e166c3](8e166c3)) * add CODE_OF_CONDUCT.md ([d7fcc0b](d7fcc0b)) * add coverage badge ([1756f67](1756f67)) * add empty docusaurus site ([a6581f9](a6581f9)) * add getting started chapters ([041fc8c](041fc8c)) * add intro and architecture ([63999f2](63999f2)) * add open graph meta ([7560590](7560590)) * add pages about helm and matchmaking ([jeremylvln#215](https://github.com/bridgesplash/Shulker/issues/215)) ([554277b](554277b)) * add recipes for plugins, pod overrides, and proxy protocol ([jeremylvln#117](https://github.com/bridgesplash/Shulker/issues/117)) ([ad935a2](ad935a2)) * add section about network admins ([471960c](471960c)) * add section about player sync ([5040512](5040512)) * add text about commercial license ([40ecd71](40ecd71)) * fix dead link in README ([048bb66](048bb66)) * fix dead links ([9994604](9994604)) * fix header dead link ([037575b](037575b)) * fix proxyfleet in example ([jeremylvln#110](https://github.com/bridgesplash/Shulker/issues/110)) ([99d7ca0](99d7ca0)) * fix typo ([jeremylvln#193](https://github.com/bridgesplash/Shulker/issues/193)) ([78650e1](78650e1)) * mention agones ([79e66e4](79e66e4)) * migrate to vitepress ([jeremylvln#165](https://github.com/bridgesplash/Shulker/issues/165)) ([fe7a7e4](fe7a7e4)) * promote next to latest ([8178611](8178611)) * **README:** add readme ([7ae2dce](7ae2dce)) * remove default pages and add crowdin ([c87ab9a](c87ab9a)) * separate pages for next and latest ([b5afb9d](b5afb9d)) * squoosh screenshots ([d20cedb](d20cedb)) * theme and draft pages ([b7c5c7d](b7c5c7d)) * update Agones prerequisites ([ef4dcd5](ef4dcd5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.