fix(shulker-operator): do not let Agones map the server ports #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 30.81% 30.79% -0.03%
==========================================
Files 57 57
Lines 3115 3114 -1
==========================================
- Hits 960 959 -1
Misses 2155 2155
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jeremylvln
pushed a commit
that referenced
this pull request
Jan 8, 2024
## [0.5.1](v0.5.0...v0.5.1) (2024-01-08) ### 🐛 Bug Fixes 🐛 * **deps:** update dependency io.grpc:grpc-netty-shaded to v1.60.1 ([#322](#322)) ([8303b6e](8303b6e)) * **deps:** update dependency net.kyori:adventure-platform-bungeecord to v4.3.2 ([#326](#326)) ([a9d6e34](a9d6e34)) * **deps:** update grpc to v1.60.1 ([#323](#323)) ([87e8641](87e8641)) * **shulker-operator:** do not let Agones map the server ports ([#330](#330)) ([d1a9955](d1a9955)) ### 📚 Documentation 📚 * promote next to latest ([8178611](8178611))
|
🎉 This PR is included in version 0.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Agones maps the ports of the GameServer, it also binds a host port. It's not something we want for the servers as the network is routed through the proxies, so internally of the Kubernetes cluster.