Fix scrollTop problem in chrome #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T1883 PR/SR+
Added String.matches() [#1886]
…on a separate line.
…of just ArrayList
QuickStart links pointed to 404s; also, “relatively links” → “relative links”
[#1885] Fixed ArrayList Iterator
…nit tests from PVector.pde to PVector-sub.pde and added a whole bunch more unit tests for sub.
Fixed ArrayList constructor to accept 'anything that has .toArray' instead of just ArrayList
I Added PVector.sub() which makes the PVector.sub perf go from 311ms to 190ms!
Fix documentation regarding exit() and draw() [#1197]
rebind Processing.instances when processingInstances is cleared
Bug 1923 - Ignore image type in loadImage
improved width/height check in 2d context rect()
* Issue #99 : withTouch() touchstart event was relying on direct access to the eventHandlers array within the Processing module to remove any existing mouse event handlers. Instead of exposing the eventHandlers array directly, this change exposes a method called detachEventHandlersByTypeMatch() which takes a regex of event types, iterates through the list of existing event handlers, and detaches the handlers that match.
* have LICENSE in the root dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new here.
I think that there's a problem calling body.scrollTop in Chrome, the position of mouse doesn't get a good mouseY position (chrome says that body.scrollTop is deprecated).
My solution is adding two lines after line 8227 in function calculateOffset(curEvent, event):
offsetX += document.documentElement.scrollLeft;offsetY += document.documentElement.scrollTop;But sure there is a better solutions, i'll be waiting new tips...