Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode fixes #69

Merged
merged 6 commits into from Sep 30, 2020
Merged

Dark mode fixes #69

merged 6 commits into from Sep 30, 2020

Conversation

mralext20
Copy link
Contributor

closes #65

i do not have any vive basestations to test those features. can you check, @jeroen1602 ?

@jeroen1602
Copy link
Owner

I also don't have any Vive base stations, their support is completely theoretical. You can enable getting fake devices in the list for testing by going to lib/main.dart and removing the comment on line 26 (don't forget to import the FakeBLEBackend.

But I'll have a look at it.

Copy link
Owner

@jeroen1602 jeroen1602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. Could you also change the selected background for the main devices page, the nicknames page and the Vive Base station ids page. (For the Nickname page and the Vive Base station ids page you can tap the 🚫 10 times to generate fake data (debug only)).

I'm not sure what to change the background color to because Theme.of(context).selectedRowColor doesn't look good in dark mode.

@BlakCake
Copy link

I have Vive Base Stations so maybe I can help?

@jeroen1602
Copy link
Owner

@BlakCake that is great! can we continue this conversation in #15?

@jeroen1602 jeroen1602 added this to the v1.1.0 milestone Sep 29, 2020
Copy link
Owner

@jeroen1602 jeroen1602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the help.

@jeroen1602 jeroen1602 merged commit 5ee15be into jeroen1602:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small dark theme fixes.
3 participants