Updates for 2023 (PR's, Issues, and minor updates) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a member of a private leaderboard with 150 users and it's not always easy to find myself in this crowd. That's why I suggest to add a background color for my row.
yes, I've really met two players with same timestamp on private leaderboard
The PR had a tad fragile approach as shown by the more complex html that's possible. We temporarily fix that before we'll go for a more robust solution.
We use the `owner_id` from the JSON to reliably detect the logged in user. Furthermore we use color constants (and one that's a bit more subtle while we're at it).
…e-charts into svatal-same_time_order_fix
Made "biti" star 1 for day 1 on the exact same time as another user to make sure there's a test case where the star index should be leading.
Unfortunately `ownwer_id` is not the logged in user, but the owner of the current leaderboard. I found no other reliable way to deduce the currently logged in user. So we resort to this hackish way after all. This will fail for edge cases, most obviously the one where two members of a board have the same username. But it seems worth it?
…nt-of-code-charts into rioj7-feature-emojimedal-2-medalsvg
…oj7/advent-of-code-charts into rioj7-feature-emojimedal-2-medalsvg" See #56 See #56 (comment) See next commit Reverting the SVG option, since (a) I'm not sure about usage rights of these SVG's, and (b) I think it's quite an edge case to have a system with no font that contains these unicode characters. Instead I will do a follow-up commit to add a few extra fallback fonts to help older systems find medals anyways. This reverts commit 41581cc, reversing changes made to 77e218f.
Closes #56 The SVG option was more reliable, but I worry about (a) usage rights and (b) adding more moving parts for only very old systems with fonts that miss these characters.
…dvent-of-code-charts into rioj7-feature-minutes-star-all-players
…ts into baaroth-chart_config
Although I think these kinds of docs (or better yet: TypeScript) are absolutely fantastic and almost necessary, they also impose a burden on maintenance: I would need to keep them up to date, because incorrect docs are worse than no docs. Knowing myself and the style of this (pet) project, I don't think I am willing to take that responsibility at the moment. So I will strip these changes from the PR for now. If this is a must-have for others to contribute more I am open to having a bit further discussion in an open issue. But I'd rather not have types for a handful of things in this project only relevant to one PR. Hope that makes sense. PS. I've purposely first merged these docs in, and then removed them, so that we may grab them from history if we change our minds on this matter.
Fixes #81 Probably the build scripts and so forth are not entirely correct yet, but we'll fix that when we get to creating a new release, so we just deal with a commit that might not be publishable.
This broke after the Chart.js update, let's fix it!
This broke in Chart.js v4 upgrade, so let's fix it!
Fixes #33 Also updates release notes.
Last year I already upgraded to v3 only to find out that Firefox doesn't support it at all yet. Later I think I read there's a bunch of problems with v3 rollout. So I've decided to switch back to v2 just until at least Firefox also fully supports v3.
On a whim I decided to change the last graph. I personally just did not like the way it worked. When you make it show only your own data (if reasonably possible) it becomes much more useful imho.
|
I've tried out the build scripts and unpacked/debug addon in Chrome and Firefox, and the new features seem to work well. Marking this PR ready, will do a final check before merging. |
jeroenheijmans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #79 (more 2023 updates may go in separate PRs)
Fixes #4
Fixes #56
Fixes #76
Fixes #81
Fixes #33
See also #54
Should automatically mark #55 as merged
Should automatically mark #78 as merged
Should automatically mark #62 as merged
Should automatically mark #73 as merged
Should automatically mark #60 as merged
Should automatically mark #58 as merged