Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or remove Implicit Flow branch #43

Open
jeroenheijmans opened this issue Jul 10, 2020 · 2 comments
Open

Update or remove Implicit Flow branch #43

jeroenheijmans opened this issue Jul 10, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@jeroenheijmans
Copy link
Owner

Someone let us know that the implicit-flow branch is broken at the moment.

The implicit-flow branch relies on demo.identityserver.io which recently removed the implicit client completely.

Three options:

  • remove the implicit flow branch
  • update the branch to use another demo IDS
  • update the branch to warn the user to configure their own IDS
@jeroenheijmans jeroenheijmans added the bug Something isn't working label Jul 10, 2020
@jeroenheijmans
Copy link
Owner Author

Linked issue reported a similar problem, turned out the master branch also needed a fix.

Pushed one for master this morning, but the implicit-flow still needs work. That client was completely deleted from the IDS that I was using, and the "API calls" the app makes rely on that same IDS (so cannot just change the config, this branch needs some more work).

@jeroenheijmans
Copy link
Owner Author

Perhaps "archiving" the branch is the way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant