feat: improved tests

jeroenrinzema · Aug 16, 2019 · cbcf529 · cbcf529
1 parent 35d75d3
commit cbcf529
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 29 deletions.
diff --git a/dialects/mock/main_test.go b/dialects/mock/main_test.go
@@ -6,6 +6,8 @@ import "testing"
 func TestNewDialectConstruction(t *testing.T) {
 	dialect := NewDialect()
 
+	dialect.Open()
+
 	if dialect.Consumer() == nil {
 		t.Fatal("no dialect consumer")
 	}

diff --git a/group_test.go b/group_test.go
@@ -214,35 +214,37 @@ func TestAwaitEventAction(t *testing.T) {
 	message.Next()
 }
 
-// // TestAwaitEventIgnoreParent tests if plausible to await a event with action
-// func TestAwaitEventIgnoreParent(t *testing.T) {
-// 	group, client := NewMockClient()
-// 	defer client.Close()
-
-// 	timeout := 100 * time.Millisecond
-// 	parent := types.NewMessage("parent", 1, nil, nil)
-
-// 	messages, closer, err := group.NewConsumerWithDeadline(timeout, EventMessage)
-// 	if err != nil {
-// 		t.Fatal(err)
-// 		return
-// 	}
-
-// 	go func() {
-// 		event := parent.NewMessage("ignore", 1, nil, nil)
-// 		err := group.ProduceEvent(event)
-// 		if err != nil {
-// 			t.Error(err)
-// 		}
-// 	}()
-
-// 	defer closer()
-
-// 	_, err = group.AwaitEventWithAction(messages, types.ParentID(parent.ID), "process")
-// 	if err != ErrTimeout {
-// 		t.Error(err)
-// 	}
-// }
+// TestAwaitEventIgnoreParent tests if plausible to await a event with action
+func TestAwaitEventIgnoreParent(t *testing.T) {
+	group, client := NewMockClient()
+	defer client.Close()
+
+	timeout := 100 * time.Millisecond
+	parent := types.NewMessage("parent", 1, nil, nil)
+
+	messages, closer, err := group.NewConsumerWithDeadline(timeout, EventMessage)
+	if err != nil {
+		t.Fatal(err)
+		return
+	}
+
+	go func() {
+		event := parent.NewMessage("ignore", 1, nil, nil)
+		err := group.ProduceEvent(event)
+		if err != nil {
+			t.Error(err)
+		}
+	}()
+
+	defer closer()
+
+	message, err := group.AwaitEventWithAction(messages, types.ParentID(parent.ID), "process")
+	if err != ErrTimeout {
+		t.Error(err)
+	}
+
+	message.Next()
+}
 
 // TestEventConsumer tests if events get consumed
 func TestEventConsumer(t *testing.T) {
@@ -462,3 +464,22 @@ func TestMessageMarked(t *testing.T) {
 	}()
 	message.Await()
 }
+
+// TestNewConsumer tests if able to create a new consumer
+func TestNewConsumer(t *testing.T) {
+	group, client := NewMockClient()
+	defer client.Close()
+
+	var err error
+
+	_, _, err = group.NewConsumer(EventMessage)
+	if err != nil {
+		t.Error(err)
+	}
+
+	unkown := types.MessageType(0)
+	_, _, err = group.NewConsumer(unkown)
+	if err != ErrNoTopic {
+		t.Error("unexpected error", err)
+	}
+}