-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GitHub News Feed Filter) The addition of the tab 'Discover repositories' in the News Feed has broken the script functionality #121
Comments
Yeah, just got the new layout too. Already working on it, but it's not a simple replace classnames. They completely rewrote all news alerts. I hope to finish it this weekend. |
@darkred Do you have any issue related news items in your news list? |
No, I haven't. any.. |
Me neither. No issues and PR related news (and gist, but that could be because there isn't any in my feed). Also wondering if it's temporary or by design... |
I also remembered news items about members being added to repos. Those are gone too. |
I just pushed code changes that (hopefully) restores a working version of this userscript. I've not updated version numbering, because I was wondering if you have time to test it before releasing... |
Of course. I also contacted the GitHub support about the missing entries in the News Feed. |
Unfortuntately it's a feature..
And my reply: (at least I tried!)
-In case you've already read my last comment with my suggestion to you for the usernames order in the 'Users' tab- - sorry about that, I deleted it. It's fine as it is. |
I don't expect them to restore it, so those (and Member Add and Gists) are removed for now (we can always revert the commit). I just updated the userscript, if you can test again, that would be great. I probably release a new version tonight or tomorrow. Edit: About the user sorting; that seemed logic to me because the list of users always changes, and if you search for an user it's now easier to find. Another direction would have been sorting on amount of matches. |
I just released the new version of Github News Feed Filter 🎬 I've not confirmed that every filter is working (because they weren't in my news feed), so if you see anything not working let me know. The total amount of filters should always be a factor of 30. Thanks for helping with testing 🥇 |
Using FF 56.0.1 (tested in a clean profile too) with GM 3.17 and script v7.2.0.
Yesterday, an extra tab, 'Discover repositories' was added in the News Feed (blog post).
Unfortunately, this has broken the script functionality:
There's no entry in Browser Console when this happens.
@jerone, it would be great if you fixed the script, to work with the new layout. I love your script!
The text was updated successfully, but these errors were encountered: