-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Github News Feed Filter) all entries counters are zero #68
Comments
Hmm, just tested and can't confirm with same specs. The script works for me just as intended. Do you have any other userscripts running? |
No, as I've written, it also occurs in a clean FF40 stable profile, with only GM 3.3 and the script installed. And in order to confirm that we use the same Firefox version: |
Yeah same. What I did noticed was that the "More" button doesn't recount the filters. But that still gives me 30 on all news feed. I also notice that there are small changes to GitHub done today. Maybe they are in the progress of more changes. |
What is the first item in your news feed? Maybe the first item is a new filter item that isn't supported yet... |
Can you do a HTML dump of all items with the |
If I got it right, you want me to
and then click on each of these 3 elements and copy outer HTML of each entry. Also, all entries I have in news feed (apart from https://github.com/jerone/UserScripts/ ) |
So yeah, they changed something for PR news items. I don't have any PR items in my news list right now, but I'll try to find a fix for it. Thanks for helping finding the issue 💜 |
Glad to be of help. |
Greetings, @jerone 🙂 Unfortunately the issue has occurred again: There's no error in Console. Using script v8.2.5 with Tampermonkey 4.8.5867 in Chrome 70. Tested it with only TM running. Here is a screenshot of my news feed: |
I can confirm it, and they changed the HTML again. It looks like every |
Your suggestion fixes the issue. Thank you! 👍 Here is the PR: |
Today I noticed that entries counters (and sub-counters) are all zero:
![screenshot](https://camo.githubusercontent.com/7bf4f25dd458130ea51560ae3f880ef031dc92cf7d49e6ab8691d7398c53208a/687474703a2f2f692e696d6775722e636f6d2f465037696641612e6a7067)
Filtering still works ok.
This is what I get this in Browser Console when opening https://github.com/ :
Using FF40(tested in a clean profile too) with GM 3.3 and script v5.3.
The text was updated successfully, but these errors were encountered: