Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub News Feed Filter) 'Sidebar is null' error in Browser Console #114

Closed
wants to merge 1 commit into from
Closed

Conversation

darkred
Copy link
Contributor

@darkred darkred commented Aug 13, 2016

The script shows Sidebar is null error in Browser Console on users public activity stream.
This is a suggested fix.

The script shows `Sidebar is null` error in Browser Console on users public activity stream.
This is a suggested fix.
@jerone
Copy link
Owner

jerone commented Aug 14, 2016

I can confirm that GitHub News Feed Filter doesn't work anymore on users profile activity tab.
Your proposed fix actually adds the filter element on the wrong element.
But more important, it won't add the filter element on GitHub's homepage anymore!

I've just pushed a new version containing another solution. Thanks for your contribution.

@darkred
Copy link
Contributor Author

darkred commented Aug 14, 2016

Your proposed fix actually adds the filter element on the wrong element.
But more important, it won't add the filter element on GitHub's homepage anymore!

Sorry about that.

Thanks for fixing the issue !

@darkred darkred deleted the patch-1 branch August 14, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants