Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set board as generic if not defined #1943

Conversation

rzr
Copy link
Contributor

@rzr rzr commented Jul 23, 2020

Observed issue using cmake:

CMake Error at CMakeLists.txt:136 (string):
string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: https://github.com/jerryscript-project/iotjs/pulls?q=author%3Arzr
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net

Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1943
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
@rzr rzr force-pushed the sandbox/rzr/build/review/master branch from ff27c37 to 3f7b386 Compare July 24, 2020 11:13
rzr added a commit to TizenTeam/iotjs that referenced this pull request Jul 24, 2020
Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1943
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Copy link
Member

@daeyeon daeyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzr
Copy link
Contributor Author

rzr commented Jul 29, 2020

rzr added a commit to rzr/iotjs that referenced this pull request Jul 29, 2020
Observed issue using cmake:

    CMake Error at CMakeLists.txt:136 (string):
    string no output variable specified

This will help to keep iotjs in debian repo.

Change-Id: I2991d324b887e340cb676f7de8ea0dda2ea7c050
Forwarded: jerryscript-project#1943
Bug: jerryscript-project#1945
Bug-Debian: https://bugs.debian.org/957364
Origin: https://github.com/TizenTeam/iotjs/tree/sandbox/rzr/build/review/master
IoT.js-DCO-1.0-Signed-off-by: Philippe Coval rzr@users.sf.net
Copy link
Contributor

@galpeter galpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss merged commit 4cde5a8 into jerryscript-project:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants