Rework command line handling of build tool #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
added
enhancement
|
Note (to self/maintainers): this will conflict with #2370. Whichever PR gets landed first, the other will have to be rebased and conflicts resolved. |
|
@akosthekiss rebase please |
LaszloLango
reviewed
Jun 4, 2018
| @@ -319,7 +319,7 @@ max-returns=6 | |||
| max-branches=15 | |||
|
|
|||
| # Maximum number of statements in function / method body | |||
| max-statements=50 | |||
| max-statements=75 | |||
akosthekiss
force-pushed
the
rework-build-cli
branch
2 times, most recently
from
9505d9c
to
845d3f2
Compare
In `tools/build.py`: - For the sake of readability, group CLI arguments as general build options, options to control the building of components, and component-specific options. - To prevent duplications, remove the defaults from those CLI arguments that correspond to CMake options and have defaults in any of the CMakeLists. Should any of the defaults change, they will have to be changed at a single place only. (Those options that are not set on the command line of `tools/build.py` are not passed as options to `cmake` either.) - Convert `--unittests` and `--doctests` to ON/OFF options like the rest of the component switches. - Touch on some of the help messages of the CLI arguments. Other changes: - The change in `--unittests` and `--doctests` is a slightly CLI- breaking change of `tools/build.py`. Thus, follow up on this in `tools/run-tests.py`. - Move `ENABLE_ALL_IN_ONE` into `jerry-core` as it is not a general option but specific to that component. - Remove the forcing of `ENABLE_ALL_IN_ONE` for some compilers/ platforms as it is still an option, not a hard requirement. JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
akosthekiss
force-pushed
the
rework-build-cli
branch
from
845d3f2
to
5b87220
Compare
|
I've rebased and conflict-resolved the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tools/build.py:options, options to control the building of components, and
component-specific options.
arguments that correspond to CMake options and have defaults in
any of the CMakeLists. Should any of the defaults change, they
will have to be changed at a single place only. (Those options
that are not set on the command line of
tools/build.pyare notpassed as options to
cmakeeither.)--unittestsand--docteststo ON/OFF options like therest of the component switches.
Other changes:
--unittestsand--doctestsis a slightly CLI-breaking change of
tools/build.py. Thus, follow up on this intools/run-tests.py.ENABLE_ALL_IN_ONEintojerry-coreas it is not a generaloption but specific to that component.
ENABLE_ALL_IN_ONEfor some compilers/platforms as it is still an option, not a hard requirement.
JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu