Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework command line handling of build tool #2373

Merged
merged 1 commit into from Jun 6, 2018

Commits on Jun 5, 2018

  1. Rework command line handling of build tool

    In `tools/build.py`:
    - For the sake of readability, group CLI arguments as general build
      options, options to control the building of components, and
      component-specific options.
    - To prevent duplications, remove the defaults from those CLI
      arguments that correspond to CMake options and have defaults in
      any of the CMakeLists. Should any of the defaults change, they
      will have to be changed at a single place only. (Those options
      that are not set on the command line of `tools/build.py` are not
      passed as options to `cmake` either.)
    - Convert `--unittests` and `--doctests` to ON/OFF options like the
      rest of the component switches.
    - Touch on some of the help messages of the CLI arguments.
    
    Other changes:
    - The change in `--unittests` and `--doctests` is a slightly CLI-
      breaking change of `tools/build.py`. Thus, follow up on this in
      `tools/run-tests.py`.
    - Move `ENABLE_ALL_IN_ONE` into `jerry-core` as it is not a general
      option but specific to that component.
    - Remove the forcing of `ENABLE_ALL_IN_ONE` for some compilers/
      platforms as it is still an option, not a hard requirement.
    
    JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
    akosthekiss committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    5b87220 View commit details
    Browse the repository at this point in the history