-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref to function self should not create new object #2632
Ref to function self should not create new object #2632
Conversation
98c026b
to
9f748b7
Compare
Please add a test for this as well. |
9f748b7
to
162b5c8
Compare
I am also thinking about fixing this. I don't want to add a new argument for vm_run. We need to figure out something better. |
162b5c8
to
42ba64c
Compare
Measurement results (RPi2):
|
Picked from yodaos-project/ShadowNode#368 JerryScript-DCO-1.0-Signed-off-by: legendecas legendecas@gmail.com
42ba64c
to
2eea850
Compare
I have bad news. We have to do this literally according to spec. See this example:
|
Looks like the issue still exists with this PR. If we're going to address the issue in this PR? |
Started to put together a correct solution #2634 . Not completed yet. |
Can we close this in favour of #2634 ? It seems to be close to completion. |
@akosthekiss yes we can close this, #2634 is the right fix for the original issue. This PR is just a workaround which does not work correctly on every testcase. |
Picked from yodaos-project/ShadowNode#368
JerryScript-DCO-1.0-Signed-off-by: legendecas legendecas@gmail.com