Fix named function expression creation. #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
named_func_exp
branch
from
0575134
to
262c9f2
Compare
zherczeg
changed the title
|
I think this patch is ready for review. |
|
Maybe you could add a test case to check if it works as expected? |
|
Good point. I forgot it. |
zherczeg
force-pushed
the
named_func_exp
branch
from
262c9f2
to
b3d9b55
Compare
rerobika
requested changes
Dec 10, 2018
akosthekiss
reviewed
Dec 11, 2018
There was a problem hiding this comment.
LGTM in general. +1 to @rerobika 's suggestions to extend the test case.
Create a local lexical environment with the name of the function. While this is not too memory efficient, some corner cases requires its existence. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
named_func_exp
branch
from
b3d9b55
to
2f92b8f
Compare
|
Thank you for the review. Tests added, even a new one as well. |
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 20, 2018
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 21, 2018
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 21, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 24, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Dec 24, 2018
* Revert "jerry: ref to function self should not create new object (#368)" * jerry: change literal status flags to enum Picked from jerryscript-project/jerryscript#2474 * jerry: fix named function expression creation picked from jerryscript-project/jerryscript#2634 * Include test sets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a local lexical environment with the name of the function. While this is not too memory efficient, some corner cases requires its existence.