Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test code to alerts.py #108

Merged
merged 2 commits into from
May 4, 2021
Merged

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented May 4, 2021

Added test code to alerts.py

ChatworkAlerter
DingTalkAlerter
DiscordAlerter
GitterAlerter
GoogleChatAlerter
LineNotifyAlerter
MattermostAlerter
PagerTreeAlerter
ServiceNowAlerter
TelegramAlerter
VictorOpsAlerter

TODO

There is no test code for the following features yet. I plan to start when I have time.

HiveAlerter
ExotelAlerter
SesAlerter
SnsAlerter
StompAlerter
TwilioAlerter
ZabbixAlerter

ChatworkAlerter
DingTalkAlerter
DingTalkAlerter
GitterAlerter
GoogleChatAlerter
LineNotifyAlerter
MattermostAlerter
PagerTreeAlerter
ServiceNowAlerter
TelegramAlerter
VictorOpsAlerter
@nsano-rururu nsano-rururu requested a review from jertel May 4, 2021 15:22
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You brought our code coverage up another 4% from 75% to 79%. Nice job!

@jertel jertel merged commit 5b5a20e into jertel:master May 4, 2021
@nsano-rururu nsano-rururu deleted the add_testcode branch May 4, 2021 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants