-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields option to rules to allow for runtime fields and others #1193
Conversation
Thanks for the submission. I noticed you checked the box that you added unit tests, but I don't see any. Did you miss a commit? |
Sorry, you didn't miss anything. I did not include unit tests for this change. Would you like me to write some? |
Yes, please. See |
…o feat-fields-query
I have added tests, please let me know if there are any additional tests you think need to be added. |
Description
Checklist
make test-docker
with my changes.Questions or Comments