Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields option to rules to allow for runtime fields and others #1193

Merged
merged 9 commits into from
Jun 8, 2023

Conversation

Goggin
Copy link
Contributor

@Goggin Goggin commented Jun 7, 2023

Description

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel
Copy link
Owner

jertel commented Jun 8, 2023

Thanks for the submission. I noticed you checked the box that you added unit tests, but I don't see any. Did you miss a commit?

@Goggin
Copy link
Contributor Author

Goggin commented Jun 8, 2023

Sorry, you didn't miss anything. I did not include unit tests for this change. Would you like me to write some?

@jertel
Copy link
Owner

jertel commented Jun 8, 2023

Yes, please. See base_test.py and loaders_test.py which already have unit tests that should be covering those existing functions. I think get_hits() may be called indirectly via run_query() in the unit tests. load_options() should be called directly in the existing unit tests.

@Goggin
Copy link
Contributor Author

Goggin commented Jun 8, 2023

I have added tests, please let me know if there are any additional tests you think need to be added.

jertel
jertel previously approved these changes Jun 8, 2023
@jertel jertel merged commit 00874ee into jertel:master Jun 8, 2023
1 check passed
@Goggin Goggin deleted the feat-fields-query branch June 12, 2023 01:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants