Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields option to rules to allow for runtime fields and others #1193

Merged
merged 9 commits into from
Jun 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

## New features
- Add initial support for EQL - [#1189](https://github.com/jertel/elastalert2/pull/1189) - @jertel
- Add `fields` parameter to rules to be able to pull in runtimes fields, and more. [#1193](https://github.com/jertel/elastalert2/pull/1193) - @Goggin
- Add EQL support to elastalert-test-rule utility - [#1195](https://github.com/jertel/elastalert2/pull/1195) - @jertel

## Other changes
Expand Down
9 changes: 9 additions & 0 deletions docs/source/ruletypes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ Rule Configuration Cheat Sheet
+--------------------------------------------------------------+ |
| ``include`` (list of strs, default ["*"]) | |
+--------------------------------------------------------------+ |
| ``fields`` (list of strs, no default) | |
+--------------------------------------------------------------+ |
| ``filter`` (ES filter DSL, no default) | |
+--------------------------------------------------------------+ |
| ``max_query_size`` (int, default global max_query_size) | |
Expand Down Expand Up @@ -584,6 +586,13 @@ include
fields, along with '@timestamp', ``query_key``, ``compare_key``, and ``top_count_keys`` are included, if present.
(Optional, list of strings, default all fields)

fields
^^^^^^

``fields``: A list of fields that should be included in query results and passed to rule types and alerts. If ``_source_enabled`` is False,
only these fields and those from ``include`` are included. When ``_source_enabled`` is True, these are in addition to source. This is used
for runtime fields, script fields, etc. This only works with Elasticsearch version 7.11 and newer. (Optional, list of strings, no default)

top_count_keys
^^^^^^^^^^^^^^

Expand Down
3 changes: 3 additions & 0 deletions elastalert/elastalert.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,9 @@ def get_hits(self, rule, starttime, endtime, index, scroll=False):
query['stored_fields'] = rule['include']
extra_args = {}

if rule.get('fields', None) is not None:
query['fields'] = rule['fields']

try:
if scroll:
res = self.thread_data.current_es.scroll(scroll_id=rule['scroll_id'], scroll=scroll_keepalive)
Expand Down
4 changes: 4 additions & 0 deletions elastalert/loaders.py
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ def load_options(self, rule, conf, filename, args=None):
rule.setdefault('description', "")
rule.setdefault('jinja_root_name', "_data")
rule.setdefault('query_timezone', "")
rule.setdefault('fields', None)

# Set timestamp_type conversion function, used when generating queries and processing hits
rule['timestamp_type'] = rule['timestamp_type'].strip().lower()
Expand Down Expand Up @@ -393,6 +394,9 @@ def _dt_to_ts_with_format(dt):
if 'include' in rule and type(rule['include']) != list:
raise EAException('include option must be a list')

if 'fields' in rule and rule['fields'] is not None and type(rule['fields']) != list:
raise EAException('fields option must be a list')

raw_query_key = rule.get('query_key')
if isinstance(raw_query_key, list):
if len(raw_query_key) > 1:
Expand Down
1 change: 1 addition & 0 deletions elastalert/schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ properties:
items: *filter

include: {type: array, items: {type: string}}
fields: {type: array, item: {type: string}}
top_count_keys: {type: array, items: {type: string}}
top_count_number: {type: integer}
raw_count_keys: {type: boolean}
Expand Down
14 changes: 13 additions & 1 deletion tests/base_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def test_query(ea):
size=ea.rules[0]['max_query_size'], scroll=ea.conf['scroll_keepalive'])


def test_query_with_fields(ea):
def test_query_with_stored_fields(ea):
ea.rules[0]['_source_enabled'] = False
ea.thread_data.current_es.search.return_value = {'hits': {'total': {'value': 0}, 'hits': []}}
ea.run_query(ea.rules[0], START, END)
Expand All @@ -112,6 +112,18 @@ def test_query_with_fields(ea):
size=ea.rules[0]['max_query_size'], scroll=ea.conf['scroll_keepalive'])


def test_query_with_fields(ea):
ea.rules[0]['fields'] = ['test_runtime_field']
ea.thread_data.current_es.search.return_value = {'hits': {'total': {'value': 0}, 'hits': []}}
ea.run_query(ea.rules[0], START, END)
ea.thread_data.current_es.search.assert_called_with(body={
'query': {'bool': {
'filter': {'bool': {'must': [{'range': {'@timestamp': {'lte': END_TIMESTAMP, 'gt': START_TIMESTAMP}}}]}}}},
'sort': [{'@timestamp': {'order': 'asc'}}], 'fields': ['test_runtime_field']},
index='idx', ignore_unavailable=True, _source_includes=['@timestamp'],
size=ea.rules[0]['max_query_size'], scroll=ea.conf['scroll_keepalive'])


def test_query_with_unix(ea):
ea.rules[0]['timestamp_type'] = 'unix'
ea.rules[0]['dt_to_ts'] = dt_to_unix
Expand Down
10 changes: 8 additions & 2 deletions tests/loaders_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
'use_count_query': True,
'email': 'test@test.test',
'aggregation': {'hours': 2},
'include': ['comparekey', '@timestamp']}
'include': ['comparekey', '@timestamp'],
'fields': ['test_runtime_field']}

test_args = mock.Mock()
test_args.config = 'test_config'
Expand Down Expand Up @@ -275,6 +276,8 @@ def test_load_rules():
assert isinstance(rules['rules'][0]['alert'][0], elastalert.alerts.Alerter)
assert isinstance(rules['rules'][0]['timeframe'], datetime.timedelta)
assert isinstance(rules['run_every'], datetime.timedelta)
assert isinstance(rules['rules'][0]['fields'], list)
assert 'test_runtime_field' in rules['rules'][0]['fields']
for included_key in ['comparekey', 'testkey', '@timestamp']:
assert included_key in rules['rules'][0]['include']

Expand Down Expand Up @@ -363,7 +366,10 @@ def test_load_disabled_rules():


def test_raises_on_missing_config():
optional_keys = ('aggregation', 'use_count_query', 'query_key', 'compare_key', 'filter', 'include', 'es_host', 'es_port', 'name')
optional_keys = (
'aggregation', 'use_count_query', 'query_key', 'compare_key', 'filter', 'include', 'es_host', 'es_port',
'name', 'fields'
)
test_rule_copy = copy.deepcopy(test_rule)
for key in list(test_rule_copy.keys()):
test_rule_copy = copy.deepcopy(test_rule)
Expand Down