Begin alerter refactoring and migration #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jertel I'm not sure if there's something going on with the edit: I've tried re-triggering the build once, and even though it restarted it got stuck with the same message. |
|
I've seen this happen before. It's an issue with GitHub. I'll check back later today and try to re-run it. |
- Create a new alerters folder - Move the Zabbix and OpsGenie alerters to the folder - Refactor to load the alerters from the folder - Add a new test for the Zabbix alerter Once this is merged (and if we are happy with this format for the migration), I will do all the other alerters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged (and if we are happy with this format for the migration),
I will do all the other alerters.