Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans on making a snappy packages? (Question) #20

Closed
titus-anromedonn opened this issue Jun 30, 2019 · 6 comments · Fixed by #86
Closed

Any plans on making a snappy packages? (Question) #20

titus-anromedonn opened this issue Jun 30, 2019 · 6 comments · Fixed by #86

Comments

@titus-anromedonn
Copy link

Love the project, this is awesome, great job!

I was wondering, do you have any plans on making a snappy package?

@dawidd6
Copy link
Collaborator

dawidd6 commented Jun 30, 2019

If there is such demand, I could do it by directly contributing snapcraft.yaml to this repo.

But I would better like not to be the one who uploads to Snap store.
Definitely would be the best if the uploader was the original creator of software. @jesseduffield

NOTE for Jesse: you already have a launchpad account so there is simply no need to make another account and Canonical provides this service for automatic builds straight from Github repo.

@titus-anromedonn
Copy link
Author

titus-anromedonn commented Jun 30, 2019

If there is such demand, I could do it by directly contributing snapcraft.yaml to this repo.

But I would better like not to be the one who uploads to Snap store.
Definitely would be the best if the uploader was the original creator of software. @jesseduffield

NOTE for Jesse: you already have a launchpad account so there is simply no need to make another account and Canonical provides this service for automatic builds straight from Github repo.

Agreed.

Personally, I would prefer to have the snappy package available for download instead of having to manually download the linux binary myself, but that's just me being lazy!

@jesseduffield
Copy link
Owner

I'm happy to do this if I can get some guidance on what needs to be done :P

@dawidd6
Copy link
Collaborator

dawidd6 commented Jul 1, 2019

I'll try to tackle this today.

@dawidd6
Copy link
Collaborator

dawidd6 commented Jul 1, 2019

Seems like you are using goreleaser and it has snapcraft support:
https://goreleaser.com/customization/#Snapcraft

Maybe we should do it this way?

Also, I think that classic confinement will be required, because using strict one, lazydocker cannot communicate with docker installed not as snap. Which leads us to another problem - classicaly confined snaps need manual approval from Canonical, to be accepted into Store. It's a single action, but still.

@dawidd6
Copy link
Collaborator

dawidd6 commented Jul 1, 2019

I made two variants:

  • added snapcraft.yaml
  • modified .goreleaser.yml

master...dawidd6:snapcraft

IMO goreleaser would be better in that case. Already tested it, builds and runs fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants