Skip to content

Update Goreleaser - #86

Merged
jesseduffield merged 3 commits into
jesseduffield:masterfrom
dawidd6:goreleaser
Jul 4, 2019
Merged

Update Goreleaser#86
jesseduffield merged 3 commits into
jesseduffield:masterfrom
dawidd6:goreleaser

Conversation

@dawidd6

@dawidd6 dawidd6 commented Jul 3, 2019

Copy link
Copy Markdown
Collaborator

Already done:

  • moved env from local context to global
  • defined separate build for snap
  • build for armv6 and armv7
  • fixed some deprecations:
    • archive -> archives
    • brew -> brews
  • replaced 386 with x86 (for consistency with x86_64)
  • added snapcraft (strict confinement)

To be done:

  • container logs cannot be obtained, cause there is no docker command in snap
  • same problem will be with docker-compose

Notes:

I managed to make it strict confined by defining docker-support plug.

So user after install would need to manually execute:
snap connect lazydocker:docker-support
or
snap connect lazydocker:docker if Docker is installed as snap I suppose.

If someone wants to test this, run:

goreleaser --skip-publish --snapshot --skip-sign --rm-dist

closes: #20

Useful links for @jesseduffield :

https://docs.snapcraft.io/registering-your-app-name

- move env from local context to global
- define separate build for snap
- build for armv6 and armv7
- fix some deprecations:
  - archive -> archives
  - brew -> brews
- replace 386 with x86 (for consistency with x86_64)
- add snapcraft (classic confinement, must be consulted with Canonical)
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files          13       13           
  Lines        1080     1080           
=======================================
  Hits          255      255           
  Misses        813      813           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572ff63...8dfd8b6. Read the comment docs.

@codecov-io

codecov-io commented Jul 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files          13       13           
  Lines        1080     1080           
=======================================
  Hits          255      255           
  Misses        813      813           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572ff63...73d9a36. Read the comment docs.

@jesseduffield

Copy link
Copy Markdown
Owner

LGTM

@jesseduffield
jesseduffield merged commit b002816 into jesseduffield:master Jul 4, 2019
@dawidd6
dawidd6 deleted the goreleaser branch July 4, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any plans on making a snappy packages? (Question)

3 participants