Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked out of terminal after editing config #51

Closed
pvande opened this issue Jul 1, 2019 · 3 comments
Closed

Locked out of terminal after editing config #51

pvande opened this issue Jul 1, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@pvande
Copy link
Contributor

pvande commented Jul 1, 2019

Describe the bug
After editing my config from "inside" lazydocker, I was faced with a prompt that would not actually accept any input.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Status'
  2. Click on 'About'
  3. Press 'e' to edit the config
  4. Exit vim with :q
  5. Press 'Enter' to dismiss the prompt

Expected behaviour
I should be taken back to lazydocker's UI.

Screenshots

image

Desktop (please complete the following information):

  • OS: macOS 10.14.5
  • Lazydocker Version 0.2.4 (from Homebrew)

Additional context
This issue does not consistently reproduce for me. It triggered for me in a session where I'd been exploring for a while, but I haven't seen it again in a new session.

@pvande pvande added the bug Something isn't working label Jul 1, 2019
@jesseduffield
Copy link
Owner

I've seen this myself a couple times too. I believe it's an issue with how we're using termbox-go. termbox-go wasn't really made to be initialized and closed multiple times in a single session, so it has some package-level variables being used for state. I think that's the core of the issue: it might take a bit of work on the termbox-go fork to make it deal better with e.g. exiting PollEvent() when we want it to, and then being able to listen for more events when we call PollEvent() again. I think it's something along those lines

@ghostsquad
Copy link

Package level variable anti pattern strikes again!

@jesseduffield
Copy link
Owner

I haven't had this problem for a while so I'll close this off. If other people still get the issue let me know and we can reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants