Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdg package instead of configdir #129

Merged
merged 2 commits into from Jul 18, 2019
Merged

Use xdg package instead of configdir #129

merged 2 commits into from Jul 18, 2019

Conversation

dawidd6
Copy link
Collaborator

@dawidd6 dawidd6 commented Jul 13, 2019

Closes: #125

@michaelrigart if you could test it.

@codecov-io
Copy link

codecov-io commented Jul 13, 2019

Codecov Report

Merging #129 into master will increase coverage by 0.07%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   23.55%   23.62%   +0.07%     
==========================================
  Files          13       13              
  Lines        1091     1092       +1     
==========================================
+ Hits          257      258       +1     
  Misses        821      821              
  Partials       13       13
Impacted Files Coverage Δ
pkg/config/app_config.go 77.04% <80%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f384e57...e413252. Read the comment docs.

@michaelrigart
Copy link

Hi @dawidd6

Thank you for the update. What are the build steps I can execute to build the xdg branch on macos?

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Jul 15, 2019

git clone https://github.com/jesseduffield/lazydocker
cd lazydocker
git checkout xdg
go build -mod=vendor

@michaelrigart
Copy link

@dawidd6 : thank you for the info.

build succeeded and I can confirm the config and log are now written to ~/.config/jesseduffield/lazydocker and no longer to ~/Library/Application Support

@dawidd6
Copy link
Collaborator Author

dawidd6 commented Jul 18, 2019

@michaelrigart thanks for testing!

It's merge time I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS - XDG base directory specification
3 participants