Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with hanging app on startup #8

Merged
merged 3 commits into from Jun 30, 2019
Merged

Fix bug with hanging app on startup #8

merged 3 commits into from Jun 30, 2019

Conversation

jesseduffield
Copy link
Owner

This PR kills two birds with one stone.
bird #1: the app hanging when the docker daemon was not set (actually happened whenever there was an error before the gui started polling events)
bird #2: the process kill function now checks to see if the process is actually there before trying to kill it

@jesseduffield jesseduffield changed the title Nil pointer Fix bug with hanging app on startup Jun 30, 2019
@codecov-io
Copy link

codecov-io commented Jun 30, 2019

Codecov Report

Merging #8 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   18.12%   18.09%   -0.04%     
==========================================
  Files          12       12              
  Lines        1048     1050       +2     
==========================================
  Hits          190      190              
- Misses        852      854       +2     
  Partials        6        6
Impacted Files Coverage Δ
pkg/commands/os.go 32.24% <0%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588ff79...d317bc3. Read the comment docs.

@jesseduffield jesseduffield merged commit 9c8c88e into master Jun 30, 2019
@jesseduffield jesseduffield deleted the nil-pointer branch July 7, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants