Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading speed of commits and reflog when log.showSignature=true #1911

Merged

Conversation

Ryooooooga
Copy link
Contributor

Loading speed of commits and reflog is very slow when log.showSignature=true.
スクリーンショット 2022-05-04 19 38 06
スクリーンショット 2022-05-04 19 37 54

maybe related to #1901 (I couldn't reproduce the panic)

@jesseduffield
Copy link
Owner

Nice work, few things:

  1. At first I thought this might get in the way of Show GPG signature indicator in Commits #1897 but looking here it seems that the git log formatter allows for showing gpg status so this should be fine
  2. do we need to actually pass the -c arg or can we just go --show-signature=false
  3. does this require a particular git version to work?
  4. We're still calling canExtractCommit from getHydratedRebasingCommits. I assume that method should be updated as well?

@Ryooooooga Ryooooooga force-pushed the feature/fix-log-show-signature branch from 7338f35 to bd5f67e Compare May 6, 2022 14:05
@Ryooooooga
Copy link
Contributor Author

Ryooooooga commented May 6, 2022

  1. do we need to actually pass the -c arg or can we just go --show-signature=false
  2. does this require a particular git version to work?

I did not know about --show-signature.
--no-show-signature flag is only available in Git 2.10.0 or later (-c log.showSignature=false is available in any version).

$ docker run --rm -it -v "$PWD:/app" ryooooooga/git:2.9.5 -C /app log --no-show-signature
fatal: unrecognized argument: --no-show-signature

$ docker run --rm -it -v "$PWD:/app" ryooooooga/git:2.9.5 -C /app -c log.showSignature=false log
commit 2144fefee9abb434c70eea7a83bbac96a71e8cb0
Author: Ryooooooga <eial5q265e5@gmail.com>
Date:   Fri May 6 22:25:12 2022 +0900
...
  1. We're still calling canExtractCommit from getHydratedRebasingCommits. I assume that method should be updated as well?

canExtractCommit could be removed in the same way.

@jesseduffield
Copy link
Owner

--no-show-signature flag is only available in Git 2.10.0 or later

Ah okay, fair enough

@Ryooooooga Ryooooooga force-pushed the feature/fix-log-show-signature branch from 0768604 to 6d8e2cd Compare May 7, 2022 14:11
@Ryooooooga Ryooooooga force-pushed the feature/fix-log-show-signature branch from 6d8e2cd to 490a964 Compare May 10, 2022 10:47
@jesseduffield jesseduffield merged commit 7b0bb68 into jesseduffield:master May 15, 2022
@jesseduffield
Copy link
Owner

Nice one

@Ryooooooga Ryooooooga deleted the feature/fix-log-show-signature branch May 15, 2022 12:53
stefanhaller added a commit that referenced this pull request Mar 28, 2024
… true (#3431)

- **PR Description**

For people who have the log.showsignature git config set to true, trying
to reword a signed commit would put the signature verification into the
subject field and the commit subject into the description field of the
commit message panel. Amending commits, adding co-authors to a commit,
and copying a commit message to the clipboard would all be broken in a
similar way.

Slightly related is #1911, but back then it was more about performance
than wrong behavior, it seems.

Fixes #3425.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants