-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loading speed of commits and reflog when log.showSignature=true
#1911
Merged
jesseduffield
merged 2 commits into
jesseduffield:master
from
Ryooooooga:feature/fix-log-show-signature
May 15, 2022
Merged
Improve loading speed of commits and reflog when log.showSignature=true
#1911
jesseduffield
merged 2 commits into
jesseduffield:master
from
Ryooooooga:feature/fix-log-show-signature
May 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nice work, few things:
|
Ryooooooga
force-pushed
the
feature/fix-log-show-signature
branch
from
May 6, 2022 14:05
7338f35
to
bd5f67e
Compare
I did not know about $ docker run --rm -it -v "$PWD:/app" ryooooooga/git:2.9.5 -C /app log --no-show-signature
fatal: unrecognized argument: --no-show-signature
$ docker run --rm -it -v "$PWD:/app" ryooooooga/git:2.9.5 -C /app -c log.showSignature=false log
commit 2144fefee9abb434c70eea7a83bbac96a71e8cb0
Author: Ryooooooga <eial5q265e5@gmail.com>
Date: Fri May 6 22:25:12 2022 +0900
...
|
Ah okay, fair enough |
Ryooooooga
force-pushed
the
feature/fix-log-show-signature
branch
from
May 7, 2022 14:11
0768604
to
6d8e2cd
Compare
Ryooooooga
force-pushed
the
feature/fix-log-show-signature
branch
from
May 10, 2022 10:47
6d8e2cd
to
490a964
Compare
Nice one |
6 tasks
stefanhaller
added a commit
that referenced
this pull request
Mar 28, 2024
… true (#3431) - **PR Description** For people who have the log.showsignature git config set to true, trying to reword a signed commit would put the signature verification into the subject field and the commit subject into the description field of the commit message panel. Amending commits, adding co-authors to a commit, and copying a commit message to the clipboard would all be broken in a similar way. Slightly related is #1911, but back then it was more about performance than wrong behavior, it seems. Fixes #3425.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading speed of commits and reflog is very slow when
log.showSignature=true
.maybe related to #1901 (I couldn't reproduce the panic)