Turn off the highlight of the suggestions panel when it loses focus

[stefanhaller]

• PR Description

The highlight is normally turned off in HandleFocusLost, but that's not called when using ReplaceContext (and changing this would be a lot of work, it seems), so turn it off manually for now.

For a moment I considered whether we want to show the new inactive highlight when switching from suggestions to the prompt (actually this did happen on master), but I decided against it for several reasons:

• it's not quite the right concept (the suggestions view is not the "parent" context of the prompt),
• there's no benefit from seeing one of the suggestions selected (and the selection would change arbitrarily when changing the filter string)
• there would be visual problems when the suggestions become empty, in which case we would still highlight the first empty row (which you can only see if you set the gui.theme.inactiveViewSelectedLineBgColor config to some color). Now this could be considered a bug in the focus management of the suggestions panel, but it doesn't seem worth fixing this; the problem goes away by turning off the highlight.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 696b8ba1	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (696b8ba)	Report Missing	Report Missing	Report Missing
Head commit (9b73b68)	48707	41613	85.44%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3696)	6	6	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩