Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deleteObjects function to a NSManagedObjectContext extension #76

Merged
merged 1 commit into from
Apr 29, 2016
Merged

Move deleteObjects function to a NSManagedObjectContext extension #76

merged 1 commit into from
Apr 29, 2016

Conversation

Liquidsoul
Copy link
Collaborator

Pull request checklist

This fixes the deleteObjects part of issue #69.

What's in this pull request?

  • deleteObjects is now an extension's method on NSManagedObjectContext
  • extension lives in a dedicated CoreDataExtensions.swift file.

@jessesquires jessesquires added this to the 4.0.0 milestone Apr 28, 2016
@jessesquires jessesquires self-assigned this Apr 28, 2016
@jessesquires
Copy link
Owner

🎉

Looks like conflicts, so github can't merge automatically. mind resolving? 😄

Extension lives in its dedicated `CoreDataExtensions.swift` file.
@Liquidsoul
Copy link
Collaborator Author

Done 😊

@codecov-io
Copy link

Current coverage is 94.36%

Merging #76 into develop will not change coverage

@@            develop        #76   diff @@
==========================================
  Files            27         28     +1   
  Lines          1931       1931          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1822       1822          
  Misses          109        109          
  Partials          0          0          

Powered by Codecov. Last updated by 222eeb4

@jessesquires jessesquires merged commit 9774208 into jessesquires:develop Apr 29, 2016
@jessesquires
Copy link
Owner

🎉

@Liquidsoul Liquidsoul deleted the issue_69_deleteObjects branch April 29, 2016 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants