Multithreading Concurrency Violation Fix while merge #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.60%@@ develop #83 diff @@
==========================================
Files 28 28
Lines 1679 1681 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1605 1607 +2
Misses 74 74
Partials 0 0
|
|
Awesome 🎉 Thanks @saurabytes ! 😄 |
|
Just released Thanks again @saurabytes ! Perfect PR. |
|
hey @saurabytes -- this was a great PR. i've sent you an invite to be a collaborator 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
What's in this pull request?
With the new stack model we are now merging the context changes across main and background contexts via notification. But this merge results in concurrency violation. This PR fixes that issue by issuing the merge in the context's
performBlockUpdated the Example project to use a background context(on trashing all company data objects) linked to parent background context to cover all bases.