Added a dataSource method to insert custom menu items

[eliburke]

For issue #1321

[codecov-io]

Current coverage is 64.79%

Merging #1563 into develop will decrease coverage by 1.72%

1. 2 files (not in diff) in ...Controller/Factories were deleted. more
2. 2 files (not in diff) in ...ssagesViewController were deleted. more
3. 12 files (not in diff) in ...ViewController/Views were modified. more
   • Partials -5
   • Hits -67
4. 7 files (not in diff) in ...ViewController/Model were modified. more
   • Partials -4
   • Hits -61
5. 5 files (not in diff) in ...iewController/Layout were modified. more
   • Partials -15
   • Hits -31
6. 3 files (not in diff) in ...Controller/Factories were modified. more
   • Partials -2
   • Hits -16
7. 4 files (not in diff) in ...ontroller/Categories were modified. more
   • Hits -8
8. 1 files (not in diff) in ...ssagesViewController were modified. more
   • Partials -2
   • Hits -6
9. File ...agesViewController.m was modified. more
   • Partials -7
   • Hits -38

@@            develop      #1563   diff @@
==========================================
  Files            62         59     -3   
  Lines          2264       2170    -94   
  Methods         634          0   -634   
  Messages          0          0          
  Branches        136          0   -136   
==========================================
- Hits           1506       1406   -100   
- Misses          758        764     +6   
  Partials          0          0          

Powered by Codecov. Last updated by e0016e4...eeee168

[jessesquires]

hey @eliburke — i decided to merge #1281 and then pushed 8c29756 — this seems like a decent middle ground for 7.x.

i definitely want to include your changes here for 8.0 — although, I'd really like to redesign the menu controller stuff completely. it's all sort of "hacked on top" right now. it would be good to contain all this logic in a separate class and have a separate MenuItemDelegate/DataSource (instead of piggy-backing on the messagesDataSource).

Thoughts?

[eliburke]

@jessesquires Better half a loaf ... 😆

The #1281 update to JSQMessagesComposerTextView:canPerformAction: appears to have fixed the problem I had with pasting images (for the image attachment PR).

If you have a couple minutes to jot down any thoughts about how you'd like to have the MenuItem delegate/data source class work in 8.0 I can get started trying to put something together.

Here are some questions off the top of my head:

• Is this new class only for collection view cells? Cell menus need the most customization, but maybe someone has a need for additional menu items on the ComposerTextView, and both involve UIMenuController and juggling selectors...
• Should maybe expose selectedIndexPathForMenu
• Media messages should not be blacklisted in shouldShowMenuForItemAtIndexPath
• should the cell menu be restored automatically? the willShow / willHide methodology in fix custom action show in JSQMessagesComposerTextView #1281 requires developers to add and remove custom menus themselves
• I think it would be good to have fine-grained control over whether JSQMessageData items can be copy / pasted.

I can think of a few ways to do this:

1. adding BOOL copyable; and -(void) copy: to the JSQMessageData protocol, maybe with another BOOL in the MenuItem delegate for mediaItemsCopyable.
2. use something like the existing registerMenuAction design with a registerMenuCopy: and 'registerMenuPaste:` (each would take a class, and the copy and paste logic would live within the collection)
3. beef up registerMenuAction to take additional parameters to indicate media and &etc

[jessesquires]

Hello everyone!

I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:

http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/

Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊

Thanks for understanding,
— jsq