This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Fix crash on delete pressed for JSQMessagesComposerTextView #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 60.97%@@ develop #1664 diff @@
==========================================
Files 62 62
Lines 2264 2265 +1
Methods 637 638 +1
Messages 0 0
Branches 137 137
==========================================
Hits 1381 1381
- Misses 811 812 +1
Partials 72 72
|
|
Thanks @GianniCarlo ! 👍 |
|
Hm, after looking at iMessage, I think we should remove |
|
In fact, shouldn't we just call then we wouldn't need to enumerate all those selectors.... |
|
you are right @jessesquires , if we remove the |
GianniCarlo
force-pushed
the
crash-delete
branch
from
346d215
to
cfa5872
Compare
|
Updated pull request |
|
Here's what I'm suggesting: - (BOOL)canPerformAction:(SEL)action withSender:(id)sender {
[UIMenuController sharedMenuController].menuItems = nil;
return [super canPerformAction:action withSender:sender];
}wouldn't this fix the crash and keep the fix from #1281? |
|
oooh, hadn't seen that issue, yup then the function is indeed needed, I'll update it now |
GianniCarlo
force-pushed
the
crash-delete
branch
from
cfa5872
to
43ce2f5
Compare
…w` to call super
|
updated 👍 |
|
Awesome. So this fixes the crash, and still fixes #1281? |
|
yes, fixes the crash as the default list of actions doesn't include the action |
|
Thanks so much for jumping on this so quickly @GianniCarlo ! 🎉 |
GianniCarlo
force-pushed
the
crash-delete
branch
from
43ce2f5
to
8c741fd
Compare
|
cherry-picked into |
Slessi
pushed a commit
to preeo/JSQMessagesViewController
that referenced
this pull request
Aug 22, 2016
…w` to call super (jessesquires#1664). Fixes jessesquires#1663.
Luke47
pushed a commit
to ubergrape/JSQMessagesViewController
that referenced
this pull request
Jan 30, 2017
…w` to call super (jessesquires#1664). Fixes jessesquires#1663.
pcoltau
added a commit
to TeletronicsDotAe/JSQMessagesViewController
that referenced
this pull request
Apr 16, 2017
…iewController * 'master' of https://github.com/jessesquires/JSQMessagesViewController: (86 commits) ImageOptim on assets (jessesquires#1845) update changelog and spec for 7.3.4 Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744) update changelog and version for 7.3.3 Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663. Update CHANGELOG and version nums for 7.3.2 fix KVO crash. close jessesquires#1631 formatting small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640 Update CHANGELOG.md update CHANGLOG. bump version numbers Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623) bump version numbers Update CHANGELOG.md provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338 follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize copy attributes clean up fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063 - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563 ...
pcoltau
added a commit
to TeletronicsDotAe/JSQMessagesViewController
that referenced
this pull request
Apr 16, 2017
…nch3 * origin/master: (66 commits) ImageOptim on assets (jessesquires#1845) update changelog and spec for 7.3.4 Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744) update changelog and version for 7.3.3 Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663. Update CHANGELOG and version nums for 7.3.2 fix KVO crash. close jessesquires#1631 formatting small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640 Update CHANGELOG.md update CHANGLOG. bump version numbers Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623) bump version numbers Update CHANGELOG.md provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338 follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize copy attributes clean up fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063 - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
This fixes issue #1663.
What's in this pull request?
Fixes the crash on delete menu button pressed