Changed Rust Icon #520
Closed
Changed Rust Icon #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rust icon seemed kind of noisy, so I took an SVG of Ferris the Rustacean and modified it for better appearance at a small size. I tried to make sure it fits within the style of the package as a whole while being distinctly 'Rust.' Let me know if I need to do anything more to integrate it properly. I figured modifying the existing SVG file and changing the color in the mapping.less would be sufficient.
|
Welcome to a blast from the past on this PR - so, I don't think this SVG renders how you want:
It's kinda like a sad crab 😄. I am open to this though! I'll do a quick twitter poll on what people think too. What it looks like now:
vs
|
|
Alright, looks like with an almost 50% majority, keeping it the same has won |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust icon seemed kind of noisy, so I took an SVG of Ferris the Rustacean and modified it for better appearance at a small size. I tried to make sure it fits within the style of the package as a whole while being distinctly 'Rust.'
Let me know if I need to do anything more to integrate it properly. I figured modifying the existing SVG file and changing the color in the mapping.less would be sufficient. I don't actually use atom, I'm here from Visual Studio Code, which apparently adopted them as well. 🤷♂️
Either way, like the project!