Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is preventing upgrades to @typescript-eslint packages #1398

Closed
Tracked by #665
LukaPrebil opened this issue Jul 11, 2023 · 5 comments · Fixed by #1400
Closed
Tracked by #665

Plugin is preventing upgrades to @typescript-eslint packages #1398

LukaPrebil opened this issue Jul 11, 2023 · 5 comments · Fixed by #1400
Labels

Comments

@LukaPrebil
Copy link

LukaPrebil commented Jul 11, 2023

Hi,

due to having a dependencies on @typescript-eslint/parser, @typescript-eslint/eslint-plugin and @typescript-eslint/utils at major version 5, it is not straightforward to upgrade those packages to version 6 in projects that also require eslint-plugin-jest.

This is npm output after bumping versions of @typescript-eslint packages in our projects

image

There is already a renovate PR opened to upgrade #1397

@cristobalgvera
Copy link

cristobalgvera commented Jul 13, 2023

As a workaround (not a solution) you can temporarily override the peer dependency in the package.json.

{
  // ...
  "devDependencies": {
    // ...
    "@typescript-eslint/eslint-plugin": "^6.0.0",
    "eslint-plugin-jest": "^27.2.2",
    // ...
  },
  "overrides": {
    "eslint-plugin-jest": {
      "@typescript-eslint/eslint-plugin": "$@typescript-eslint/eslint-plugin"
    }
  }
}

@SimenB
Copy link
Member

SimenB commented Jul 13, 2023

Ah, didn't know they'd released a v6. Fix incoming 🙂

@SimenB
Copy link
Member

SimenB commented Jul 13, 2023

Hah, we got #1397 😅 Missed it amongst my other notifications...
image

@SimenB
Copy link
Member

SimenB commented Jul 13, 2023

They've completely broken types for projects (like this) that doesn't use nodenext resolution in typescript-eslint/typescript-eslint#6458, so we won't be able to verify it works on CI.

Can start by just expanding the peer dep, tho

github-actions bot pushed a commit that referenced this issue Jul 13, 2023
## [27.2.3](v27.2.2...v27.2.3) (2023-07-13)

### Bug Fixes

* allow `@typescript-eslint/eslint-plugin` v6 as peer dep ([#1400](#1400)) ([04b2bf2](04b2bf2)), closes [#1398](#1398)
@github-actions
Copy link

🎉 This issue has been resolved in version 27.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants