Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rules): add prefer-inline-snapshots #129

Merged
merged 3 commits into from Jul 17, 2018
Merged

feat(rules): add prefer-inline-snapshots #129

merged 3 commits into from Jul 17, 2018

Conversation

tryggvigy
Copy link
Contributor

@tryggvigy tryggvigy commented Jul 16, 2018

This PR will

Implement the prefer-inline-snapshots rule. This rule serves to encourage interspersing snapshots inline in test file code over writing them to a separate _snapshots_/*.snap file.

Why?

The believe is that the snapshot test is easier to comprehend when it can be seen as a whole. This is especially convenient during code-reviews.

Copy link
Member

@SimenB SimenB left a comment

Thanks for this!

Mind adding it to the main readme as well?

SimenB
SimenB approved these changes Jul 17, 2018
Copy link
Member

@SimenB SimenB left a comment

Thanks!

@SimenB SimenB merged commit b5a13fd into jest-community:master Jul 17, 2018
1 check failed
@SimenB
Copy link
Member

@SimenB SimenB commented Jul 17, 2018

This will probably fail the publish seeing as npm has revoked all tokens and I haven't updated this... Will do later today

@tryggvigy
Copy link
Contributor Author

@tryggvigy tryggvigy commented Jul 17, 2018

Awesome, thank you!

@SimenB
Copy link
Member

@SimenB SimenB commented Jul 17, 2018

🎉 This PR is included in version 21.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants