chore: backport non-breaking changes from next #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for using private identifiers, which are used by `@typescript-eslint` v3. We don't use `tsc` to actually build any code, so this change only affects the typechecking side of the compiler.
`@typescript-eslint` v3 changed the structure of their types, meaning that we need to type the options for `valid-title`. This in turn means we have to provide a direct default value for the `disallowedWords` option, in turn meaning we have to adjust our test to ensure proper coverage instead of relying on the `default` property.
`@typescript-eslint` v3 changed the structure of their types, meaning that the `suggest` property in `TSESLint.ReportDescriptor` is now marked as being `readonly`, so we can't assign to it. The easiest way around this is to just refactor our code to be slightly different, given it doesn't impact behaviour, performance, or clarity.
|
🎉 This PR is included in version 23.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says in the title. Reduces the diff between
master&next- the main ones I wanted were the eslint rules,tsconfigtarget change, and code restructures, but figured I'd bring a few things along just to reduce the diff further.