Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport non-breaking changes from next #607

Merged
merged 6 commits into from
Jun 21, 2020
Merged

chore: backport non-breaking changes from next #607

merged 6 commits into from
Jun 21, 2020

Commits on Jun 21, 2020

  1. chore: enable eslint core rules enabled by v3 of @typescript-eslint

    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    edecf91 View commit details
    Browse the repository at this point in the history

  2. chore: target es2015 in tsconfig.json 

    This is required for using private identifiers, which are used by
`@typescript-eslint` v3.

We don't use `tsc` to actually build any code, so this change only
affects the typechecking side of the compiler.
    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    0df5fa5 View commit details
    Browse the repository at this point in the history

  3. chore(valid-title): adjust default for disallowedWords option 

    `@typescript-eslint` v3 changed the structure of their types, meaning
that we need to type the options for `valid-title`.

This in turn means we have to provide a direct default value for the
`disallowedWords` option, in turn meaning we have to adjust our test to
ensure proper coverage instead of relying on the `default` property.
    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    a15c580 View commit details
    Browse the repository at this point in the history

  4. chore(prefer-expect-assertions): adjust how report object is built 

    `@typescript-eslint` v3 changed the structure of their types, meaning
that the `suggest` property in `TSESLint.ReportDescriptor` is now marked
 as being `readonly`, so we can't assign to it.

The easiest way around this is to just refactor our code to be slightly
different, given it doesn't impact behaviour, performance, or clarity.
    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    2babbe6 View commit details
    Browse the repository at this point in the history

  5. chore: apply prettier to renovate.json

    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    655a201 View commit details
    Browse the repository at this point in the history

  6. chore: explicitly set prettier options

    @G-Rath
    G-Rath committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    1932de0 View commit details
    Browse the repository at this point in the history