Add toBeValidDate matcher #133
Conversation
tejasbubane
force-pushed
the
add-tobe-valid-date-matcher
branch
8 times, most recently
from
24e9099
to
374d019
Compare
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 90 92 +2
Lines 425 434 +9
Branches 70 72 +2
=====================================
+ Hits 425 434 +9
Continue to review full report at Codecov.
|
| @@ -0,0 +1,7 @@ | |||
| let is = type => value => Object.prototype.toString.call(value) === `[object ${type}]`; | |||
There was a problem hiding this comment.
This might be a useful function to pull out into utils and then import here
|
|
||
| let isValidDate = value => hasDateType(value) && !isNaN(value) && !isNaN(value.getTime()); | ||
|
|
||
| export default expected => isValidDate(expected); |
There was a problem hiding this comment.
This can just be:
export default isValidDate;We don't need both the left and right hand sides of the invocation :)
| @@ -0,0 +1,7 @@ | |||
| let is = type => value => Object.prototype.toString.call(value) === `[object ${type}]`; | |||
|
|
|||
| let hasDateType = is('Date'); | |||
There was a problem hiding this comment.
Would it be possible to use const for consistency with other matchers?
|
Love this @tejasbubane I've added a couple of minor nitpicks but looks awesome! Would you be able to merge master in too to fix the conflicts? |
tejasbubane
force-pushed
the
add-tobe-valid-date-matcher
branch
from
374d019
to
01a6dca
Compare
|
@mattphillips I have updated both |
|
Thanks @tejasbubane |
Issue: #117
What
Add new matcher
toBeValidDate.Why
As suggested in the issue.
Notes
Housekeeping
yarn contributor)