Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typings for vitest 0.31.0 #600

Merged
merged 1 commit into from May 23, 2023
Merged

feat: support typings for vitest 0.31.0 #600

merged 1 commit into from May 23, 2023

Conversation

GuillaumeRahbari
Copy link
Contributor

@GuillaumeRahbari GuillaumeRahbari commented May 10, 2023

Feature
closes #598

What

Support of vitest 0.31.0. See the issue #598

Why

Vitest made a Breaking Change that can be seen here

Notes

Housekeeping

  • Unit tests
  • Documentation is up to date
  • No additional lint warnings
  • Typescript definitions are added/updated where relevant

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

🦋 Changeset detected

Latest commit: 5eebad7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jest-extended Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #600 (2bf092b) into main (0ab61c3) will not change coverage.
The diff coverage is n/a.

❗ Current head 2bf092b differs from pull request most recent head 5eebad7. Consider uploading reports for the commit 5eebad7 to get more accurate results

@@            Coverage Diff            @@
##              main      #600   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines          674       674           
  Branches       290       290           
=========================================
  Hits           674       674           

@SimenB
Copy link
Member

SimenB commented May 15, 2023

@GuillaumeRahbari If you want this to be released, please add a changeset like the bot mentions

@GuillaumeRahbari
Copy link
Contributor Author

Hi @SimenB 👋
I just added it :)

@Tomas2D
Copy link

Tomas2D commented May 18, 2023

Looking forward to this 🙏🏻

@SimenB SimenB merged commit 5b80ca8 into jest-community:main May 23, 2023
20 checks passed
@GuillaumeRahbari GuillaumeRahbari deleted the support-vitest-0.31.0 branch May 24, 2023 07:37
@GuillaumeRahbari
Copy link
Contributor Author

Hi @SimenB 👋
Thanks for merging it :)

Do you know why it has not been released ? 🤔

@SimenB
Copy link
Member

SimenB commented May 24, 2023

Waiting for #605 to be merged

@burtek
Copy link

burtek commented Jun 6, 2023

@GuillaumeRahbari , @SimenB this change break types for vitest, see #610

This was referenced Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in vitest
4 participants