New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support vitest 0.31.0 #614
fix: support vitest 0.31.0 #614
Conversation
🦋 Changeset detectedLatest commit: 4b1a658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7ee051c
to
4b1a658
Compare
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 674 674
Branches 290 290
=========================================
Hits 674 674 |
I think for the pipeline to pass, we'd need a dependency on vitest. I don't think we'd want to do that. |
How about supplying an empty type stub for vitest just for lint/typecheck? |
That's another option, but we'd then have to keep those signatures in sync with whatever changes Vitest makes (not sure how heavy a maintenance burden that is). Also, if those signatures change and we want to support multiple versions of Vitest, we'd have to export multiple type files for each version. I'm willing to revisit this if we can find a reasonable path forward. In the mean time, I've merged #636. |
I'm going to close this PR for now, but please feel welcome to open another one if there are ideas for alternative approaches we should discuss. |
Bug
closes #610
What
Support of vitest 0.31.0. See the issue #598
Why
Vitest made a Breaking Change that can be seen here
This PR did not allow to fully support vitest types
Notes
Housekeeping