Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure when the debug CodeLens is displayed #292

Merged
merged 7 commits into from May 19, 2018
Merged

Configure when the debug CodeLens is displayed #292

merged 7 commits into from May 19, 2018

Conversation

seanpoulter
Copy link
Member

This PR adds a new setting to control when the debug CodeLens appears above a test. Set "jest.debugCodeLens.showWhenTestStateIn" to any of combination of "fail", "pass", "skip", "unknown" to your liking. It defaults to the current behaviour.

Can you think of a better name for the setting?

This will close #240.

@coveralls
Copy link

coveralls commented Apr 1, 2018

Pull Request Test Coverage Report for Build 371

  • 19 of 19 (100.0%) changed or added relevant lines in 4 files are covered.
  • 55 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.633%

Files with Coverage Reduction New Missed Lines %
src/extension.ts 4 68.57%
src/JestExt.ts 51 53.87%
Totals Coverage Status
Change from base Build 368: 0.2%
Covered Lines: 589
Relevant Lines: 753

💛 - Coveralls

@seanpoulter
Copy link
Member Author

Here's a screenshot of the auto-complete in .vscode/settings.json in action:

screen shot 2018-03-30 at 16 34 06

@orta
Copy link
Member

orta commented Apr 2, 2018

I think the name makes sense

@orta
Copy link
Member

orta commented May 12, 2018

I merged some PRs which caused a few conflicts

@seanpoulter
Copy link
Member Author

Thanks for the follow-up on this one @orta. I've rebased and added one unrelated commit that modifies .gitignore. Hopefully we can sort out some of these regressions. 🥞🍴

@seanpoulter seanpoulter requested a review from orta May 19, 2018 22:27
@orta
Copy link
Member

orta commented May 19, 2018

Cool yep, nice work 👍

@orta orta merged commit 75d1deb into jest-community:master May 19, 2018
legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Configure when the debug CodeLens is displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"debug" tooltip only shows when test is failing
3 participants