Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test result match fallback in the imperfect world #724

Merged
merged 13 commits into from
Jun 14, 2021

Conversation

connectdotz
Copy link
Collaborator

This PR aims to work around v4 test result match-related issues due to various external factors. Mainly by adding "match-by-name" and "match-by-location" as the fallback mechanism when context-match failed for whatever reason.

This PR has a dependency on jest-community/jest-editor-support#71


fix #719
fix #715
fix #697

@coveralls
Copy link

coveralls commented Jun 5, 2021

Pull Request Test Coverage Report for Build 968

  • 202 of 202 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 93.928%

Totals Coverage Status
Change from base Build 967: -0.1%
Covered Lines: 2037
Relevant Lines: 2124

💛 - Coveralls

@connectdotz connectdotz requested a review from stephtr June 6, 2021 16:57
@connectdotz
Copy link
Collaborator Author

@stephtr sorry to ping you early as this doesn't compile until the next jest-editor-support release, just want to give you a head-up hoping you would have time to look at the code sooner.

I have made some structural change in the context match code, would love to have a 2nd pair of eyes to make sure. Thanks.

@connectdotz connectdotz merged commit cb41e37 into jest-community:master Jun 14, 2021
@connectdotz connectdotz deleted the better-match-fallback branch June 14, 2021 01:48
@stephtr
Copy link
Member

stephtr commented Jun 27, 2021

I'm really sorry that even though I started, I didn't manage to finish the review in a timely manner. Unfortunately, my availability for working on reviews is not really predictable, but realistically I won't manage to work on larger structural changes in the near-time.

Thank you anyway for your great work! The few times I'm currently using this extension, it is always a pleasure to notice the improvements being made!

legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants