-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test result match fallback in the imperfect world #724
Improve test result match fallback in the imperfect world #724
Conversation
Pull Request Test Coverage Report for Build 968
💛 - Coveralls |
@stephtr sorry to ping you early as this doesn't compile until the next jest-editor-support release, just want to give you a head-up hoping you would have time to look at the code sooner. I have made some structural change in the context match code, would love to have a 2nd pair of eyes to make sure. Thanks. |
I'm really sorry that even though I started, I didn't manage to finish the review in a timely manner. Unfortunately, my availability for working on reviews is not really predictable, but realistically I won't manage to work on larger structural changes in the near-time. Thank you anyway for your great work! The few times I'm currently using this extension, it is always a pleasure to notice the improvements being made! |
This PR aims to work around v4 test result match-related issues due to various external factors. Mainly by adding "match-by-name" and "match-by-location" as the fallback mechanism when context-match failed for whatever reason.
This PR has a dependency on jest-community/jest-editor-support#71
fix #719
fix #715
fix #697