jest-circus feature parity with jest-jasmine

[aaronabramov]

TODO items:
fix broken test.
to run all tests using jest-circus update this require line
https://github.com/facebook/jest/blob/19384094dc7ac5cd77e4eacf611d76abe5837063/packages/jest-runner/src/run_test.js#L63
with a path to the adapter:

require('jest-circus/build/legacy_code_todo_rewrite/jest_adapter.js').default

and run

./jest

failing tests:

• integration-tests/__tests__/snapshot.test.js (@aaronabramov)
• integration-tests/__tests__/jasmine_async.test.js (@aaronabramov)
• integration-tests/__tests__/globals.test.js (@thymikee)
• packages/jest-cli/src/__tests__/search_source.test.js (@aaronabramov)
• integration-tests/__tests__/lifecycles.js (@aaronabramov)
• integration-tests/__tests__/failures.test.js (@SimenB)
• integration-tests/__tests__/test_name_pattern.test.js (@aaronabramov)
• integration-tests/__tests__/location_in_results.test.js (@captbaritone)
• integration-tests/__tests__/override-globals.test.js (@aaronabramov)
• integration-tests/__tests__/each.test.js (@mattphillips)
• integration-tests/__tests__/timer_use_real_timers.test.js (@thymikee)

PRs that i opened but never had a chance to merge (need to come back and fix a few things):
#3819
#3824

also this is a new feature that was added to jasmine https://github.com/facebook/jest/pull/4016/files

[suchipi]

Thanks @aaronabramov, I'll take a look at this this weekend

[suchipi]

I'm confused; I ran the tests with the jest-circus adapter (as far as I can tell) and I'm not seeing any failures.

I ran:

./jest --testRunner '<rootDir>/packages/jest-circus/build/legacy_code_todo_rewrite/jest_adapter.js'

In the repo root, and saw no failures except for some tests that failed because they depended on mercurial, which I didn't have installed.

After installing mercurial, I ran the same command again, and saw no failures.

I was expecting to see some failures and that those would lead me to the work that needed to be done. Am I misunderstanding the situation?

[cpojer]

All the integration tests will still use Jasmine. You could probably change Jest's default config to use jest-circus and then see which integration tests fail, or go into each folder in integration_tests and run individually with circus.

[suchipi]

Ok, changing the default for testRunner in jest-cli/src/cli/args.js and running yarn run build worked, I see the failures now. Thanks!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.