Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-circus: feature parity #6328

Merged
merged 2 commits into from
May 30, 2018
Merged

Conversation

thymikee
Copy link
Collaborator

@thymikee thymikee commented May 28, 2018

Summary

jest-circus is now fully compatible with Jasmine.
cc @captbaritone

Fixes #4362

Test plan

Ideas how to make
https://github.com/facebook/jest/blob/a43fd6c75d2f38616407a70c69ccaee666cb4f61/scripts/ConditionalTest.js#L13-L15
more env independent?

This is the only place we use it:
https://github.com/facebook/jest/blob/9310e9ce497cd2e186c00e70dbc5165706ba5a0d/e2e/__tests__/location_in_results.test.js#L39

Or should we create 2 tests, one for circus, second fo jasmine?

@thymikee
Copy link
Collaborator Author

Or until we kill jest-jasmine2 we can just run 2 CI jobs as we do now, that's totally fine :)

@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #6328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6328   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         228      228           
  Lines        8705     8705           
  Branches        3        3           
=======================================
  Hits         5562     5562           
  Misses       3142     3142           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b77278...da0bcca. Read the comment docs.

@@ -14,22 +14,6 @@ const ConditionalTest = {
return process.env.JEST_CIRCUS === '1';
},

skipSuiteOnJasmine() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably need this when we start adding tests for things that we fixed in circus but that don't work in jasmine (like nested test or running hooks when there's no tests)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, brought it back

@cpojer cpojer merged commit fd2cb8b into jestjs:master May 30, 2018
@cpojer
Copy link
Member

cpojer commented May 30, 2018

Amazing work, guys.

@thymikee thymikee deleted the fix/circus-feature-parity branch March 16, 2019 10:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-circus feature parity with jest-jasmine
6 participants