Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-resolve): usage of node: imports for builtin modules #11638

Closed
wants to merge 1 commit into from
Closed

fix(jest-resolve): usage of node: imports for builtin modules #11638

wants to merge 1 commit into from

Conversation

theoludwig
Copy link
Contributor

Summary

Fixes #11637

Currently, when using node: for importing something, jest fails (see the issue #11637 for more details).

@facebook-github-bot
Copy link
Contributor

Hi @divlo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #11638 (7cea174) into master (7a64ede) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11638   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files         312      312           
  Lines       16335    16338    +3     
  Branches     4734     4737    +3     
=======================================
+ Hits        11273    11276    +3     
  Misses       5034     5034           
  Partials       28       28           
Impacted Files Coverage Δ
packages/jest-resolve/src/resolver.ts 56.45% <100.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a64ede...7cea174. Read the comment docs.

@theoludwig theoludwig changed the title fix: usage of node: imports for builtin modules fix(jest-resolve): usage of node: imports for builtin modules Jul 3, 2021
@theoludwig
Copy link
Contributor Author

cc @SimenB

@theoludwig theoludwig deleted the fix/node-imports-builtin-modules branch August 27, 2021 09:55
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Usage of node: imports for builtin modules
4 participants