feat(resolver): support node: prefix when loading core modules

[SimenB]

Summary

Ref nodejs/node#37246 (comment)

I haven't bothered to add any node version guard. So even though only v16 supports it in require, Jest will support it across all runtimes. I think that's fine. Keeping track of all the changes to node modules is doing my head in 😅

Closes #11638
Closes #11686

Test plan

Added unit test

[thymikee]

👍🏼

[SimenB]

We should probably throw the correct error if node: is used for non-code modules as well.

[dnalborczyk]

is this going into the 26.x release or into 27.x?

[SimenB]

27

[SimenB]

I forgot it before the release, though 😀 Will try to find the time soonish to finish this

[cpojer]

I'll review once you rebase this.

[theoludwig]

Oops, only find out now that there is already a PR for this.
There are 2 related PRs, to fix the same thing:

• fix(jest-resolve): usage of node: imports for builtin modules #11638
• feat(jest-resolve): detect node:-prefixed built-in modules #11686

There is also this issue #11637

It is all duplicates of this PR, but it is implemented differently.
At least you have the choice of the implementation, once jest support node: prefix, don't forget to close the appropriate PRs and issues.

[antongolub]

@SimenB, @cpojer,

More and more Sindre's utils (globby, cpy, etc) are moving to node:* notation. Updating these dependencies in projects breaks any jest-based tests. This is becoming a real problem. Please, give the green light to the patch asap.

[antongolub]

We may do not strip the prefix if the runtime supports it:

process.version.slice(1, 3) < 16
semver.lt(process.version, 'v16')

ref: https://nodejs.org/api/modules.html#modules_core_modules

[SimenB]

94d1903 (#11331)

[theoludwig]

Possible to make the tests pass again and merge that ASAP?
Really want that, there are 2 similar PRs with the tests passing and it's still taking so much time to get this feature/fix.
My CI is currently failing because of this, don't want to undo the refactor with node: syntax in my imports.

Thanks for your work! 😄

[SimenB]

https://github.com/facebook/jest/releases/tag/v27.1.0

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.