Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(jest-changed-files): enable mercurial related test on CI #12327

merged 1 commit into from Feb 8, 2022


Copy link


Split from #12322

One mercurial related test is skipped on CI long time ago, but it works on GitHub Actions. It makes sense to enable it.

Also there is another hg test which is sometimes failing on CI possibly due to flakiness (some timeout, race condition or so). Seemed that adding jest.retryTimes is making that test pass.

Test plan

So here is the plan. First I am simply enabling the skipped test. Will try to force-push few times, if there is flakiness I will add jest.retryTimes and will force-push few times to restart CI again. This way we can check if jest.retryTimes is really necessary.

Copy link

SimenB commented Feb 8, 2022

Awesome, thanks for taking the time to dig into this @mrazauskas! Flaky CI has been annoying for a long time

Copy link

Codecov Report

Merging #12327 (b76d4e4) into main (201901f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12327   +/-   ##
  Coverage   67.25%   67.25%           
  Files         330      330           
  Lines       17354    17354           
  Branches     5073     5073           
  Hits        11671    11671           
  Misses       5651     5651           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201901f...b76d4e4. Read the comment docs.

@mrazauskas mrazauskas force-pushed the ci-mercurial-tests branch 3 times, most recently from 98186aa to 6a9d406 Compare February 8, 2022 09:56
Copy link

SimenB commented Feb 8, 2022

Is it passing every time now? 😅

Copy link
Contributor Author

Indeed. Runs with no issues. Perhaps let’s leave it for few of days and then I will force-push again.

Copy link

SimenB commented Feb 8, 2022

This specific one is not running, so it's not a flaky one. I'll land this, but understanding why other tests are failing sporadically would be nice...

@SimenB SimenB merged commit 0e3013a into jestjs:main Feb 8, 2022
@mrazauskas mrazauskas deleted the ci-mercurial-tests branch February 8, 2022 15:16
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants