fix: Expected signature to be an Uint8Array

[dylancom]

Parsing lightning network payment requests currently fail within a jsdom test environment.
(using libs such as: https://github.com/bitcoinjs/bolt11 or https://github.com/alexbosworth/invoices within your front-end)

In similar issues it has been adviced to set the testenvironment to node testEnvironment: node, but we need to render react components in our test.

[facebook-github-bot]

Hi @dylancom!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[Biki-das]

CI is unhappy , could you check

[dylancom]

@Biki-das ran the test locally and it passed...

[Biki-das]

which test did you ran?

[dylancom]

e2e/__tests__/env.test.ts

[Biki-das]

hm.. seems odd

[mrazauskas]

Is result the same if you run yarn build && yarn jest e2e/__tests__/env.test.ts?

[dylancom]

@mrazauskas now it does fail running build beforehand.

[mrazauskas]

Hard to say what is wrong, but it must be some setup issue. Just follow How to Contribute guide – https://github.com/facebook/jest/blob/main/CONTRIBUTING.md

[dylancom]

This line: https://github.com/facebook/jest/blob/main/e2e/env-test/__tests__/equivalent.test.js#L26 makes it fail.

[dylancom]

Seems related to: #7780

[Biki-das]

as the todo above says this make the test slow, might be related to your test failing

[SimenB]

Thanks for sending a PR! However, I don't think we should merge this, unfortunately (so I'm extra sorry you had issues getting tests to run and spent extra time on it).

Uint8Array is already defined in JSDOM, we should not override it with the one from the host Node environment.

Note that Jest currently adds Buffer, but we want to stop doing that (#11241). Any other missing APIs need to be added by JSDOM, or polyfilled by your own environment extending jest-environment-jsdom.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.